Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show type for ErrUnsupportedPtrType #2

Merged

Conversation

msabramo
Copy link

@msabramo msabramo commented Jan 17, 2018

to aid in troubleshooting.

Before:

Pointer type in struct is not supported

After:

jsonapi: Can't unmarshal true (bool) to struct field `Name`, which is a pointer to `string`

Tests:

$ go test ./...
ok  	_/Users/abramowi/dev/git-repos/jsonapi	0.016s
ok  	_/Users/abramowi/dev/git-repos/jsonapi/examples	3.875s

(This is google#88 but rebased on to your branch)

to aid in troubleshooting.

Before:

```
Pointer type in struct is not supported
```

After:

```
jsonapi: Can't unmarshal true (bool) to struct field `Name`, which is a pointer to `string`
```
@msabramo msabramo force-pushed the pr-99-show-type-for-ErrUnsupportedPtrType branch from f9316df to a3b3bb2 Compare January 17, 2018 21:39
@mrowdy mrowdy merged commit bb266b4 into mrowdy:master Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants