Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main<-dev: refactor callback functions and improve timedSignature #60

Open
wants to merge 105 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 103 commits
Commits
Show all changes
105 commits
Select commit Hold shift + click to select a range
33649c7
remove approveAddressCallback
peaceandwhisky Oct 2, 2024
9ddf44a
remove revokeApprovalCallback
peaceandwhisky Oct 2, 2024
bfc4f7f
remove transferAccountCallback
peaceandwhisky Oct 2, 2024
5189fdb
remove deleteAccountCallback
peaceandwhisky Oct 2, 2024
b075140
remove unlockAccountCallback
peaceandwhisky Oct 2, 2024
2564325
add ci config for dev branch
peaceandwhisky Oct 2, 2024
7360abe
update to use verifyTimedSignature
peaceandwhisky Oct 3, 2024
eb3a71d
update timedSignature authentication error
peaceandwhisky Oct 3, 2024
2799aab
add OnlyUnlockAccount
peaceandwhisky Oct 3, 2024
2dd3bf1
add testSignWhenAccountIsLocked
peaceandwhisky Oct 3, 2024
1f009db
update contract logic for timedSignature
peaceandwhisky Oct 11, 2024
da7e1d4
update generateTimedSignature
peaceandwhisky Oct 11, 2024
5f639a5
update testVerifyTimedSignature
peaceandwhisky Oct 11, 2024
07d1af6
update testCreateAccount
peaceandwhisky Oct 11, 2024
f77a99a
update testCreateAccountCallback
peaceandwhisky Oct 11, 2024
9e3df73
update testApproveAddress
peaceandwhisky Oct 11, 2024
ed51f26
update testTransferAccount
peaceandwhisky Oct 11, 2024
46cd21d
update testIsApproved
peaceandwhisky Oct 11, 2024
45efaea
update testIsOwner
peaceandwhisky Oct 11, 2024
69e0818
update testGetAccount
peaceandwhisky Oct 11, 2024
0fc9bb9
update testRevokeApproval
peaceandwhisky Oct 11, 2024
339982a
update DeleteAccount
peaceandwhisky Oct 11, 2024
8807c68
update testUnlockAccount
peaceandwhisky Oct 11, 2024
9318252
update testSign
peaceandwhisky Oct 11, 2024
3510018
update testSignAccountIsLocked
peaceandwhisky Oct 11, 2024
721dc07
add getNonce
peaceandwhisky Oct 11, 2024
40f8ebc
update tests with adding GetNonce
peaceandwhisky Oct 11, 2024
81f1325
update for consumeNonce
peaceandwhisky Oct 15, 2024
5846acb
add targetFunctionHash to timedSignature
peaceandwhisky Oct 15, 2024
b60d502
update testCreateAccount
peaceandwhisky Oct 15, 2024
fbbd3c3
update testApproveAddress
peaceandwhisky Oct 15, 2024
cf4c496
update testTransferAccount
peaceandwhisky Oct 15, 2024
3182af3
update testIsApproved
peaceandwhisky Oct 15, 2024
b54a8d9
update testIsOwner
peaceandwhisky Oct 15, 2024
27ae237
update testGetAccount
peaceandwhisky Oct 15, 2024
bf6959e
update testRevokeApproval
peaceandwhisky Oct 15, 2024
146e997
update testDeleteAccount
peaceandwhisky Oct 15, 2024
875b2b7
update testUnlockAccount
peaceandwhisky Oct 15, 2024
05f9e57
update testSign
peaceandwhisky Oct 15, 2024
d041f9e
update testSignWhenAccountIsLocked
peaceandwhisky Oct 15, 2024
439abdb
rename Curve -> signatureAlgorithm
peaceandwhisky Oct 15, 2024
919f758
update SignatureAlgorithm Enum
peaceandwhisky Oct 15, 2024
c353a21
Merge pull request #44 from mycel-labs/reduce-callback-function
peaceandwhisky Oct 16, 2024
1f6c9f5
Merge pull request #52 from mycel-labs/rename-signature-algorithm
peaceandwhisky Oct 16, 2024
c40a818
Merge branch 'dev' into update-timed-signature
peaceandwhisky Oct 16, 2024
9e9b788
chore: rename local.compose.yaml to compose.local.yaml
foxytanuki Oct 16, 2024
560bc8a
chore: remove unused import from contract test
foxytanuki Oct 16, 2024
5b19cd1
chore: rename suave-geth.compose.yaml to compose.geth.yaml
foxytanuki Oct 16, 2024
f6a62a9
chore: replace curve to signature_algorithm
foxytanuki Oct 16, 2024
52c97c5
chore: update account struct in GetAccount
foxytanuki Oct 16, 2024
9d519d2
fix merge conflict
peaceandwhisky Oct 17, 2024
df22ea2
update error message about signatureAlgorithm
peaceandwhisky Oct 17, 2024
4b474fe
chore: fix gitignore
foxytanuki Oct 17, 2024
d1d65d1
feat: add gen-solidity-go-bindings
foxytanuki Oct 17, 2024
a20acbb
tweak: location of transferable_account_store.go
foxytanuki Oct 17, 2024
2f4bb6a
feat(test): add bind contract
foxytanuki Oct 17, 2024
fd2a157
fix: TestIsOwner
foxytanuki Oct 17, 2024
a12b723
feat(server): add taStoreContractBind
foxytanuki Oct 17, 2024
3555f19
chore(server): update populateTimedSignature to return *tas.Signature…
foxytanuki Oct 17, 2024
c03b4c7
refactor: timedSignature preparation
foxytanuki Oct 17, 2024
d13ba90
test(server): update TestTransferAccount
foxytanuki Oct 17, 2024
32bf273
test(server): update TestDeleteAccount
foxytanuki Oct 17, 2024
bb6296e
test(server): update TestUnlockAccount
foxytanuki Oct 17, 2024
f02796e
test(server): update TestApproveAccount
foxytanuki Oct 17, 2024
0a837ab
refactor
foxytanuki Oct 17, 2024
4eea750
chore(server): waitForTransaction
foxytanuki Oct 17, 2024
308cf05
chore(server): update RevokeApproval
foxytanuki Oct 17, 2024
36c9166
test(server): update TestSign not to use CCR in preparation
foxytanuki Oct 17, 2024
c870aac
tweak: server_test
foxytanuki Oct 17, 2024
78a5e49
tweak: auth_test
foxytanuki Oct 17, 2024
5303c99
chore: update scripts/e2e for TimedSignature type
foxytanuki Oct 17, 2024
5fb30e7
Merge branch 'update-timed-signature' into feat/api-timed-signature-n…
foxytanuki Oct 18, 2024
1875d3c
feat(proto): add Nonce and TargetFunctionHash to TimedSignature message
foxytanuki Oct 18, 2024
a56b722
feat(api): add Nonce and TargetFunctionHash to TimedSignature struct
foxytanuki Oct 18, 2024
7174038
chore(api): relocate transferable_account_store.go to under go/contract
foxytanuki Oct 18, 2024
a004a5e
feat(proto): add GetNonce message
foxytanuki Oct 18, 2024
7edef28
feat(api): add GetNonce()
foxytanuki Oct 18, 2024
39cdd8b
refactor(test): _newTimedSignature
foxytanuki Oct 18, 2024
38df6b8
feat(api,script): add FunctionHash constants and generating script
foxytanuki Oct 18, 2024
0e14136
chore(test): apply function hash constants
foxytanuki Oct 18, 2024
9a985ad
chore(api): update populateTimedSignature()
foxytanuki Oct 18, 2024
5d266bc
fix(test): PASS all tests in server_test
foxytanuki Oct 18, 2024
2fbeb5f
Update test/TransferableAccountStore.t.sol
peaceandwhisky Oct 18, 2024
582efdb
feat(testutils): add GetNonce
foxytanuki Oct 18, 2024
12bcf2c
update for VERIFY_TIMEDSIGNATURE
peaceandwhisky Oct 18, 2024
e7578a7
wip(test): auth_test
foxytanuki Oct 21, 2024
ac63f5f
wip(test): add validFor to NewTimedSignature
foxytanuki Oct 21, 2024
8006fbb
chore(e2e): PASS all tests
foxytanuki Oct 21, 2024
5104844
chore(test): modify signTestUtil
foxytanuki Oct 21, 2024
a89ef84
tweak
foxytanuki Oct 21, 2024
46a55ae
Merge pull request #53 from mycel-labs/chore/update-api-remove-callback
peaceandwhisky Oct 21, 2024
6fd0951
Merge pull request #47 from mycel-labs/update-timed-signature
peaceandwhisky Oct 21, 2024
4f87d12
Merge remote-tracking branch 'origin/dev' into feat/api-timed-signatu…
foxytanuki Oct 21, 2024
22d9aa1
Merge pull request #54 from mycel-labs/feat/api-timed-signature-nonce
peaceandwhisky Oct 22, 2024
b05d300
update CreateAccountResponse (#56)
peaceandwhisky Oct 22, 2024
42e68cf
dev: update generate timed signature script (#62)
peaceandwhisky Nov 1, 2024
abd1faa
dev: rename TransferAccountRequest param (#65)
peaceandwhisky Nov 1, 2024
e824ae5
update execute-withdraw-tx script (#66)
peaceandwhisky Nov 1, 2024
0c4d79d
dev: update GettingStarted with new TimedSignature (#68)
peaceandwhisky Nov 1, 2024
bd86eaa
dev: update GettingStarted for adding refer commands (#69)
peaceandwhisky Nov 1, 2024
a2aee7c
Merge branch 'main' into dev
peaceandwhisky Nov 5, 2024
19e1c4a
remove godotenv from server.go (#71)
peaceandwhisky Nov 7, 2024
5444164
add .coderabbit.yaml (#72)
peaceandwhisky Nov 7, 2024
e8fbd56
add docs about test on local (#74)
peaceandwhisky Nov 29, 2024
686fff6
dev: update by coderabbit (#73)
peaceandwhisky Nov 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .coderabbit.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
language: "en-US"
early_access: false
reviews:
profile: "chill"
request_changes_workflow: false
high_level_summary: true
poem: true
review_status: true
collapse_walkthrough: false
auto_review:
enabled: true
drafts: false
base_branches: [main, dev, feat/*, chore/*, bug/*]
chat:
auto_reply: true
2 changes: 1 addition & 1 deletion .env.example
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
PRIVATE_KEY=your_private_key
TA_STORE_CONTRACT_ADDRESS=0x8F7B5945D5213575b0fAdF876701b79B359c977b
TA_STORE_CONTRACT_ADDRESS=0xEa8a6ce7098B79Bd8B4920120734a5081046C44F
RPC_URL=https://rpc.toliman.suave.flashbots.net
WITHDRAW_TESTNET_RPC=for_signTx_network_rpc
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: CI

on:
push:
branches: [ main ]
branches: [ main, dev ]
pull_request:
branches: [ main ]
branches: [ main, dev ]

jobs:
ci:
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ out/
.DS_Store
.env

go
14 changes: 10 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,22 @@ PROTOBUF_DOCKERFILE := docker/protobuf.Dockerfile
# suave-geth
.PHONY: devnet-up devnet-down
devnet-up:
@docker compose --file ./suave-geth.compose.yaml up --detach
@docker compose --file ./compose.geth.yaml up --detach

.PHONY: devnet-down
devnet-down:
@docker compose --file ./suave-geth.compose.yaml down
@docker compose --file ./compose.geth.yaml down

# Solidity
build-solidity:
forge build --via-ir

build-solidity-extra:
forge build --extra-output-files abi bin --via-ir

gen-solidity-go-bindings:
./scripts/utils/gen-solidity-go-bindings.sh

test-solidity:
forge test --ffi --via-ir test/**/*.t.sol

Expand All @@ -38,7 +44,7 @@ vet-go:
go vet ./src/go

test-go:
go test ./src/go/... ./test/...
go test ./src/go/... ./test/... -count=1

lint-go:
golangci-lint run
Expand Down Expand Up @@ -90,7 +96,7 @@ ci: build test lint check-fmt
# Run e2e tests using docker compose
test-e2e-docker:
@echo "----- Running e2e tests on docker compose -----"
@docker compose -f local.compose.yaml up
@docker compose -f compose.local.yaml up

# Start API Server using Docker
run-api-server-docker:
Expand Down
Loading
Loading