[WIP] initial gnome 40 support

[ebeem]

Please report bugs/issues or discuss features in the discussion accompanying the alpha release for GNOME 40 support.

Still has many bugs, and only the switcher is implemented (no overview).

bugs/missing features:

• Animations (vertical) are not working yet.
• add modifier keys in configuration (or somehow use gnome's) to switch workspace and move workspace and workspace selection (working but not as expected, main modifier for moving to workspace is shift which works only for arrows now since other keys will change into another character with shift probably just needs to be added to the configuration).
• implement show/hide labels/thumbnails.
• controlling active workspace with mouse occurs even if mouse is not moved (if mouse is on the workspace popup area). Maybe only start checking for mouse position if mouse moves after showing the popup
• popup timeout is still not implemented
• workspace indicator fail to initially locate the current workspace.
• preferences/settings are not available in gnome extensions.
• wraparound is not working (controlled by the switcher popup now) (we can consider fixing Feature Request: New Wraparound Mode #135 here).
• workspace switcher toggle popup works but with no keybindings (default ones work instead), this can be fixed in _keyPressHandler in WorkspaceSwitcherPopup.js
• overview doesn't show workspaces matrix (old implementation fixed Scrolling in the vertical workspace list in the overview does not work correctly #127, I think we need to check _onScrollEvent).

minor improvements & extra features:

• styling might not be perfect, padding/merging/overflowing (better with configuration to fix Labels are very small #140 and fix Visual bug with Materia theme #12).
• controlling active workspace with mouse is only possible in last monitor
• dnd in switcher popup.
• matrix structure & animation in bottom workspaces in overview

what's good about this branch:

• better keybindings (check _keyPressHandler, we can have more configs and fix Add missing keybindings to system settings #150 here)
• switcher popup disappear with modifier key release and more interactive (like ctrl+alt) (fixes Show popup until modifiers keys are released #145 and fixes Allow mouse clicks to choose workspace in the Workspace Selector. #88)
• no caching applied (still very efficient and smooth)
• it seems like the code will be less and we will have less files (can't be sure yet, it's clear that there's no need to have 3 files for workspace switcher [base, label, thumbnail], we can easily do all with one now), no need for the other switcher popup and no need for timeout or any related features (fixes Switcher without thumbnails changes size #126).

Currently, this implements the switcher using a modifier key. I think this implementation will help us fix a lot of issues and have more flexibility. I am not going to be able to work on this gnome#40 support for about 3 weeks, I will look at it after that and try to fix current bugs.

Any contributions are welcomed. We will probably not merge this into master, once we finalize it, it's better to create a new branch because this one will probably have a lot of dirty code in it.

fixes #146

[mzur]

I removed all files related to the overview for now (they're now in the gnome-40-overview branch). We can take care of the overview once we have a proper implementation of the popup.

I think a (clean) working implementation for the popup can be merged into master and released as beta version. We can then move on and work on the remaining features (which will be quite complex I assume).

I did the same with the workspace overview (Super+W) -> gnome-40-workspace-overview.

[ebeem]

Thanks @mzur, settings are working great now.
I fixed the initial selection of workspace (always goes to 1) and the warning messages

[mzur]

Great! I'll continue to tinker with this branch a bit.

[ebeem]

I modified the option scale and its default value, now it reflects the scale of the switcher rather than the thumbnails themselves, the thumbnails will adjust accordingly (I feel this makes much more sense).

[ebeem]

Maybe I mentioned problems with the style, I tried different themes now.
I think there's a little problem with padding, but overall, even the materia theme in #12 is displaying the workspace switcher right.
Does it look good in your case @mzur?

[mzur]

The original scale value of 0.1 set the size of each thumbnail. A new default of 0.6 seems too large. I'll need to dig more into the code. Give me a few days 😉 Currently, the aspect ratio of the thumbnails seems off to me (on my system, if I increase the size so I can recognize something).

[ebeem]

@mzur it's not thumbnail scale anymore, it's switcher workspace popup scale.
So if we set 0.6, the switcher as whole will take 0.6 of the screen, and the thumbnails (depending on how many rows/columns) will fill this switcher popup which takes 60% of the screen. What do you think?

[mzur]

Setting the size of the whole switcher is definitely easier than setting the size of each thumbnail. I'll have to take a closer look at that, yet. For now, I just removed code that I want to take care of later. I'll get back to this PR in the next days.

[ebeem]

@mzur I followed the same approach we had earlier, I think your approach makes much more sense but I am not sure why the POPUP flag doesn't seem to be working properly?
I tried to figure it out but couldn't, so if can find a better approach then you can revert my commit.

[mzur]

@ebeem Thanks, I didn't notice that somehow. I think your approach is just fine. I've only changed the call to "remove" since the popup can be destroyed by other things than the "confirm" action as well.

[mzur]

Finally done with my review! Sorry it took me so long.

Updated list of issues:

• The popup disappears even though the mouse is still moving over it (with the "enable hover" option in the settings activated). Only use "enable hover" option for the Ctrl+W popup #174
• The animation of the active workspace indicator at the top of the overview is wrong when switching to a lower row. Fix animation of active workspace indicator in overview #175
• The log says "Source ID xxx was not found when attempting to remove it" whenever the popup is destroyed. Strangely this does not happen if the popup is opened with toggle=true. Investigate log warning message #176
• In the overview, you can switch to a workspace in the first row with a click but not in the second row of workspaces. Fix workspace thumbnails box size in overview #177
• In the overview you can drag and drop a window in the first row but not to the second row of workspaces. Fix workspace thumbnails box size in overview #177
• When dragging and dropping a window from and to the same workspace thumbnail in the overview the window disappears (behind the wallpaper?). You can still DnD them, though. Fix drag and drop of a window to the same workspace in the overview #178
• The workspace overview seems to break if the extension is disabled and the overview override was enabled. Overview breaks if extension is disabled #179
• The workspace thumbnails in the overview are not reset if the extension is disabled, then enabled again and then "Show workspace grid in overview" is switched off. They still show the wallpaper. They also don't reset if the whole extension is disabled in this case. Fix reset/destroy of workspace thumbnails in overview #180
• The workspace thumbnails in the overview should have vertical padding (same as horizontal). Fix padding of workspace thumbnails in overview #181
• The switcher popup without thumbnails should have the same style/look than the default switcher popup. Fix style of popup if thumbnails are disabled #182
• Implement 2D workspace display in the overview (see comment in workspacesView.js). Implement 2D layout of workspaces in overview #183

Other changes I did:

• Reorganized the settings and made options labels more consistent
• Disabled mouse hover over the popup by default
• The workspace overview popup keybindings work again

[mzur]

I think we're good to go with this one. I've extracted the remaining things to their own issues. Each of them can be handled later whenever someone is willing do some work. I've also removed GNOME 41 support again from the metadata. I'll open a separate PR for that, as I would like to have the opportunity to test and update the code there, too.

@ElijahLynn If your offer still stands, all the credit goes to @ebeem 😉

@ebeem A huge thanks again for all your work 👏 Please merge whenever you like.

[ebeem]

Thanks to you @mzur and everyone else who contributed, the branch now is way more stable.
Thanks for taking the time to spot all these issues and fix/document them, I will merge this for now and comment on the issues you created.

[MonsieurLanza]

I don’t know if this one is reported yet :
I just got my hands on a new laptop, which can handle gestures… You can slide workspaces with 3 fingers, left or right (yeah, there’s already an issue with the gesture here, in case of vertical sliding).

What happens is that when I slide a workspace (always horizontally, as I said), it re-plays the animation afterward, which is a somewhat awkward.

[mzur]

@MonsieurLanza Thanks for reporting. Could you please open a separate issue for that?

Everyone else: If you want to report bugs related to GNOME 40, please open a new issue.