-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-1329: Update AWS Secrets Manager docs #2787
DOC-1329: Update AWS Secrets Manager docs #2787
Conversation
✅ Deploy Preview for n8n-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Overall readability score: 44.88 (🟢 +0)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imchairmanm - Minor clarification. What do you think?
docs/external-secrets.md
Outdated
@@ -50,9 +50,11 @@ Your secret names can't contain spaces, hyphens, or other special characters. n8 | |||
} | |||
``` | |||
|
|||
If you'd like to be more restrictive and avoid n8n having access to all of your secrets, you'll still need to allow `secretsmanager:ListSecrets` and `secretsmanager:BatchGetSecretValue` access to all resources. This doesn't allow access to the secret values but is needed to retrieve any ARN-scoped secrets. You will need to scope `secretsmanager:GetSecretValue` to the specific Amazon Resource Names (ARNs) for the secrets you wish to share with n8n. Ensure you use the correct region and account ID in each resource ARNs. You can find the ARN details in the AWS dashboard for your secrets. | |||
You can also be more restrictive and give n8n access to select AWS Secret Manager secrets. You still need to allow the `secretsmanager:ListSecrets` and `secretsmanager:BatchGetSecretValue` permissions to access all resources. These permissions allow n8n to retrieve ARN-scoped secrets, but don't provide access to the secret values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also be more restrictive and give n8n access to select AWS Secret Manager secrets.
We're trying to say that we could allow access to specific secrets and not all here and I don't think that's clear in that sentence. Perhaps this?
You can also be more restrictive and give n8n access to select selected AWS Secret Manager secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, sorry @MarcL I don't know if I quite understand your comment. Is it that "select" in the original context doesn't necessarily communicate "a specific selection" (that was my intent) or is it something else that's confusing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a typo in my suggestion. 🤦♂️
I meant to say:
You can also be more restrictive and give n8n access to select specific AWS Secret Manager secrets.
I didn't think it was as clear that you can scope it down to specific secrets that you expose to n8n and you don't have to expose them all with the general wildcard *
.
Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Perfectly. Thanks for the added context, I'll make this change and publish.
Fixes: DOC-1329
Related: PAY-2426