-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bus timing helpers #114
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be coherent with the rest of the API (and cleared) I would rather see this implemented as an enum which would be passed to the CanSettings
constructor. Like this:
new CanSettings(BitTimming._25k)
The actual timming constants would be left to the native implementation of each platform. This would make it platform independent.
namespace nanoFramework.Device.Can | ||
{ | ||
/// <summary> | ||
/// Helper for common CAN timings for the STM32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing . at end of sentence.
/// <summary> | ||
/// 25 KBaud. | ||
/// </summary> | ||
public static CanSettings Timing500KBaud () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use small caps k
. Capital K is for Kelvin unit.
/// <summary> | ||
/// 25 KBaud. | ||
/// </summary> | ||
public static CanSettings Timing25KBaud () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please hit CTRL+K
+ CTRL+D
to have VS auto format the code.
/// <summary> | ||
/// Helper for common CAN timings for the ESP32. Values from https://github.com/espressif/esp-idf/blob/master/components/hal/include/hal/twai_types.h#L54 | ||
/// </summary> | ||
public static class CanTimingESP32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For coherence with the usual naming:
public static class CanTimingESP32 | |
public static class CanTimingEsp32 |
@@ -0,0 +1,83 @@ | |||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file name must match the name of the class, so please rename to CanTimingSTM32.cs :-)
I just pushed a different enum-style way as suggested by @josesimoes. We'd need to think about resetting the |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/// <summary> | ||
/// None. Manually setted values. | ||
/// </summary> | ||
_None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't start enums we underscore _, so you can rename them all to remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and in case of numbres, like in most here, the trick is to start with the unit. So Baud25k, etc
@emptynick please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Samples
repo will be updated once this is merged.Usage
Instead of using
You can now use
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist: