Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract public sk types to safekeeper_api #10137

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Extract public sk types to safekeeper_api #10137

merged 4 commits into from
Dec 13, 2024

Conversation

arssher
Copy link
Contributor

@arssher arssher commented Dec 13, 2024

Problem

We want to extract safekeeper http client to separate crate for use in storage controller and neon_local. However, many types used in the API are internal to safekeeper.

Summary of changes

Move them to safekeeper_api crate. No functional changes.

ref #9011

@arssher arssher requested a review from arpad-m December 13, 2024 11:51
@arssher arssher requested a review from a team as a code owner December 13, 2024 11:51
Copy link

github-actions bot commented Dec 13, 2024

7095 tests run: 6798 passed, 0 failed, 297 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.4% (8397 of 26778 functions)
  • lines: 48.0% (66620 of 138650 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
7ee5d88 at 2024-12-13T13:59:53.121Z :recycle:

@arssher arssher enabled auto-merge December 13, 2024 13:25
@arssher arssher disabled auto-merge December 13, 2024 13:26
@arssher arssher enabled auto-merge December 13, 2024 13:26
@arssher arssher added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit ce8eb08 Dec 13, 2024
82 checks passed
@arssher arssher deleted the sk-extract-client branch December 13, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants