Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase reconciler timeout after shard split #10490

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Jan 23, 2025

Sometimes, especially when the host running the tests is overloaded, we can run into reconcile timeouts in test_timeline_ancestor_detach_idempotent_success, making the test flaky. By increasing the timeouts from 30 seconds to 120 seconds, we can address the flakiness.

Fixes #10464

@arpad-m arpad-m requested a review from erikgrinaker January 23, 2025 14:44
Copy link

7381 tests run: 6996 passed, 0 failed, 385 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 33.5% (8490 of 25342 functions)
  • lines: 49.3% (71373 of 144774 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4f6fa45 at 2025-01-23T16:42:47.073Z :recycle:

@arpad-m arpad-m added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit ca6d72b Jan 23, 2025
86 checks passed
@arpad-m arpad-m deleted the arpad/increase_reconcile_timeout_split branch January 23, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_timeline_ancestor_detach_idempotent_success: increase timeout
2 participants