-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compute): Add some basic compute_ctl metrics #10504
Conversation
7403 tests run: 7052 passed, 0 failed, 351 skipped (full report)Flaky tests (11)Postgres 17
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
67d5061 at 2025-01-27T22:55:27.600Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be a nice touch if the compute migration regression tests were extended to check that that the migration metric works as expected
c3df6c5
to
de78bcd
Compare
de78bcd
to
67d5061
Compare
Yeah, also had tests on the list. Added to migrations and remote extensions testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good first iteration!
Problem
There are several parts of
compute_ctl
with a very low visibility of errors:GetSpec
).Summary of changes
Add new counters to quickly evaluate the amount of errors among the fleet.
Part of neondatabase/cloud#17590