Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconciliation details to sk membership change rfc #10514

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

arssher
Copy link
Contributor

@arssher arssher commented Jan 27, 2025

Problem

RFC pointed out the need of reconciliation, but wasn't detailed how it can be done.

Summary of changes

Add these details.

@arssher arssher requested a review from arpad-m January 27, 2025 13:04
Copy link

github-actions bot commented Jan 27, 2025

7403 tests run: 7049 passed, 1 failed, 353 skipped (full report)


Failures on Postgres 15

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_metrics_normal_work[release-pg15]"
Flaky tests (10)

Postgres 17

Postgres 16

Postgres 14

Test coverage report is not available

The comment gets automatically updated with the latest test results
8056b7b at 2025-01-28T05:44:29.693Z :recycle:

@arssher arssher force-pushed the sk-membership-rfc-reconciliation branch from 096a0d8 to 8056b7b Compare January 28, 2025 04:48
Copy link
Member

@arpad-m arpad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the open questions I had are clear to me and I think it can be implemented this way.

@arssher arssher enabled auto-merge February 4, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants