-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reconciliation details to sk membership change rfc #10514
Open
arssher
wants to merge
7
commits into
main
Choose a base branch
from
sk-membership-rfc-reconciliation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpad-m
reviewed
Jan 27, 2025
arpad-m
reviewed
Jan 27, 2025
arpad-m
reviewed
Jan 27, 2025
arpad-m
reviewed
Jan 27, 2025
arpad-m
reviewed
Jan 27, 2025
arpad-m
reviewed
Jan 27, 2025
7403 tests run: 7049 passed, 1 failed, 353 skipped (full report)Failures on Postgres 15
Flaky tests (10)Postgres 17
Postgres 16
Postgres 14
Test coverage report is not availableThe comment gets automatically updated with the latest test results
8056b7b at 2025-01-28T05:44:29.693Z :recycle: |
arpad-m
reviewed
Jan 27, 2025
arssher
force-pushed
the
sk-membership-rfc-reconciliation
branch
from
January 28, 2025 04:48
096a0d8
to
8056b7b
Compare
arpad-m
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the open questions I had are clear to me and I think it can be implemented this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
RFC pointed out the need of reconciliation, but wasn't detailed how it can be done.
Summary of changes
Add these details.