Remove PQ_LIB_DIR env var #10526
Merged
Remove PQ_LIB_DIR env var #10526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7403 tests run: 7017 passed, 0 failed, 386 skipped (full report)Flaky tests (3)Postgres 17
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
42fd2a2 at 2025-01-27T19:44:32.036Z :recycle: |
winter-loo
pushed a commit
to winter-loo/neon
that referenced
this pull request
Feb 4, 2025
We now don't need libpq any more for the build of the storage controller, as we use `diesel-async` since neondatabase#10280. Therefore, we remove the env var that gave cargo/rustc the location for libpq. Follow-up of neondatabase#10280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now don't need libpq any more for the build of the storage controller, as we use
diesel-asyncsince #10280. Therefore, we remove the env var that gave cargo/rustc the location for libpq.Follow-up of #10280