CI: add diesel print-schema check
#10527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayandin
force-pushed
the
bayandin/add-diesel-print-schema-check
branch
6 times, most recently
from
fb5eff6 to
15578bb
Compare
bayandin
force-pushed
the
bayandin/add-diesel-print-schema-check
branch
from
15578bb to
c29998c
Compare
7414 tests run: 7062 passed, 0 failed, 352 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
fce6b0e at 2025-01-31T03:44:36.887Z :recycle: |
bayandin
force-pushed
the
bayandin/add-diesel-print-schema-check
branch
from
be66b54 to
481b6b6
Compare
bayandin
force-pushed
the
bayandin/add-diesel-print-schema-check
branch
3 times, most recently
from
916f64c to
94301f1
Compare
bayandin
force-pushed
the
bayandin/add-diesel-print-schema-check
branch
from
94301f1 to
fce6b0e
Compare
fedordikarev
approved these changes
Jan 31, 2025
arpad-m
approved these changes
Jan 31, 2025
|
The steps takes ~1s to run: https://github.com/neondatabase/neon/actions/runs/13065424194/job/36456904782?pr=10527#step:25:1 |
winter-loo
pushed a commit
to winter-loo/neon
that referenced
this pull request
Feb 4, 2025
## Problem We want to check that `diesel print-schema` doesn't generate any changes (`storage_controller/src/schema.rs`) in comparison with the list of migration. ## Summary of changes - Add `diesel_cli` to `build-tools` image - Add `Check diesel schema` step to `build-neon` job, at this stage we have all required binaries, so don't need to compile anything additionally - Check runs only on x86 release builds to be sure we do it at least once per CI run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to check that
diesel print-schemadoesn't generate any changes (storage_controller/src/schema.rs) in comparison with the list of migration.Summary of changes
diesel_clitobuild-toolsimageCheck diesel schemastep tobuild-neonjob, at this stage we have all required binaries, so don't need to compile anything additionally