Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pageserver): dump read path on missing key error #10528

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jan 27, 2025

Problem

helps investigate #10482

Summary of changes

In debug mode and testing mode, we will record all files visited by a read operation, and print it out when it errors.

@skyzh skyzh requested a review from VladLazar January 27, 2025 20:39
@skyzh skyzh requested a review from a team as a code owner January 27, 2025 20:39
Copy link

github-actions bot commented Jan 27, 2025

7425 tests run: 7073 passed, 0 failed, 352 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 33.3% (8592 of 25829 functions)
  • lines: 49.1% (72335 of 147322 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
171663c at 2025-02-06T21:48:19.288Z :recycle:

@skyzh skyzh force-pushed the skyzh/read-path-debug branch from b21167d to ce947a2 Compare January 28, 2025 19:12
@skyzh
Copy link
Member Author

skyzh commented Jan 28, 2025

#10482 is already resolved in #10543 but I think this patch might be helpful for any future read errors we might encounter on the read path.

pageserver/src/tenant/timeline.rs Outdated Show resolved Hide resolved
pageserver/src/tenant/timeline.rs Outdated Show resolved Hide resolved
pageserver/src/tenant/timeline.rs Outdated Show resolved Hide resolved
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/read-path-debug branch from ce947a2 to 809baef Compare February 6, 2025 20:39
skyzh added 2 commits February 6, 2025 21:43
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from VladLazar February 6, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants