-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pageserver): repartition on L0-L1 boundary #10548
base: main
Are you sure you want to change the base?
Conversation
7425 tests run: 7031 passed, 42 failed, 352 skipped (full report)Failures on Postgres 17
Failures on Postgres 16
Failures on Postgres 15
Failures on Postgres 14
Flaky tests (4)Postgres 17
Postgres 15
Postgres 14
Test coverage report is not availableThe comment gets automatically updated with the latest test results
36985cd at 2025-02-06T22:52:45.774Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will conflict at the code level, but not semantics level, with #10547
I have been arguing for a long time to compact at disk_consistent_lsn()
and have alway met resistance from @hlinnaka , although I never understood the argument.
This here is even more extreme, because l0_min_lsn
is generally < disk_consistent_lsn
.
I'm all for it, maybe hear Heikki's concerns one last time?
a172072
to
62bc7f2
Compare
cc @hlinnaka if you have any concerns -- I'd like to merge it now so that we can observe it in staging+preprod for a weekend, and I can resolve/revert it if you don't think this is a good idea. |
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
c873856
to
286ab83
Compare
286ab83
to
36985cd
Compare
Problem
Reduce the read amplification when doing
repartition
.Summary of changes
Compute the L0-L1 boundary LSN and do repartition here.