Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storcon: refine chaos selection logic #10600

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Jan 30, 2025

Problem

In #10438 it was pointed out that it would be good to avoid picking tenants in ID order, and also to avoid situations where we might double-select the same tenant.

There was an initial swing at this in #10443, where Chi suggested a simpler approach which is done in this PR

Summary of changes

  • Split total set of tenants into in and out of home AZ
  • Consume out of home AZ first, and if necessary shuffle + consume from out of home AZ

@jcsp jcsp added c/storage/controller Component: Storage Controller a/tech_debt Area: related to tech debt labels Jan 30, 2025
@jcsp jcsp force-pushed the jcsp/storage-less-chaotic-chaos-2 branch from d483489 to ff63ad0 Compare January 30, 2025 21:39
@jcsp jcsp requested a review from skyzh January 30, 2025 21:41
@jcsp jcsp marked this pull request as ready for review January 30, 2025 21:41
@jcsp jcsp requested a review from a team as a code owner January 30, 2025 21:41
@jcsp jcsp enabled auto-merge January 30, 2025 22:23
@jcsp jcsp added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 5e0c407 Jan 30, 2025
81 checks passed
@jcsp jcsp deleted the jcsp/storage-less-chaotic-chaos-2 branch January 30, 2025 22:50
Copy link

7414 tests run: 7061 passed, 0 failed, 353 skipped (full report)


Flaky tests (7)

Postgres 17

Code coverage* (full report)

  • functions: 33.3% (8514 of 25536 functions)
  • lines: 49.1% (71513 of 145560 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ff63ad0 at 2025-01-30T22:54:14.544Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/controller Component: Storage Controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants