pageserver: remove faulty debug assertion in compaction #10610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7414 tests run: 7063 passed, 0 failed, 351 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d76a1fe at 2025-01-31T14:33:52.677Z :recycle: |
jcsp
requested review from
problame and
arpad-m
and removed request for
problame
problame
approved these changes
Jan 31, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
winter-loo
pushed a commit
to winter-loo/neon
that referenced
this pull request
Feb 4, 2025
…#10610) ## Problem This assertion is incorrect: it is legal to see another shard's data at this point, after a shard split. Closes: neondatabase#10609 ## Summary of changes - Remove faulty assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This assertion is incorrect: it is legal to see another shard's data at this point, after a shard split.
Closes: #10609
Summary of changes