fix generate matrix for olap for saturdays #10622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7414 tests run: 7062 passed, 0 failed, 352 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
aa23aab at 2025-02-01T08:12:36.653Z :recycle: |
bayandin
approved these changes
Feb 1, 2025
fedordikarev
approved these changes
Feb 1, 2025
winter-loo
pushed a commit
to winter-loo/neon
that referenced
this pull request
Feb 4, 2025
## Problem when introducing pg17 for job step `Generate matrix for OLAP benchmarks` I introduced a syntax error that only hits on Saturdays. ## Summary of changes Remove trailing comma ## successful test run https://github.com/neondatabase/neon/actions/runs/13086363907
winter-loo
pushed a commit
to winter-loo/neon
that referenced
this pull request
Feb 4, 2025
## Problem neondatabase#10616 was only intended temparily during the weekend, want to reset to prior state ## Summary of changes revert neondatabase#10616 but keep fixes in neondatabase#10622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
when introducing pg17 for job step
Generate matrix for OLAP benchmarksI introduced a syntax error that only hits on Saturdays.Summary of changes
Remove trailing comma
successful test run
https://github.com/neondatabase/neon/actions/runs/13086363907