Switch reqlsns[0].request_lsn to arrow operator in neon_read_at_lsnv() (#10620) #10687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neondatabase#10620) Switch from array subscript notation to arrow operator to make intent and readability clearer.
github-actions
bot
added
the
external
arpad-m
approved these changes
Feb 5, 2025
github-actions
bot
removed
the
approved-for-ci-run
knizhnik
approved these changes
Feb 6, 2025
github-actions
bot
removed
the
approved-for-ci-run
github-actions
bot
removed
the
approved-for-ci-run
Closed
7425 tests run: 7073 passed, 0 failed, 352 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
c073243 at 2025-02-06T17:13:44.595Z :recycle: |
|
@OBBO67 thanks for the contribution! |
Merged
via the queue into
neondatabase:main
with commit Feb 6, 2025
82cbab7
145 of 150 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the following line below uses array subscript notation which is confusing since
reqlsnsis not an array but just a pointer to a struct.Summary of changes
Switch from array subscript notation to arrow operator to improve readability of code.
Close #10620.