Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: use histogram for background job semaphore waits #10697

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Feb 6, 2025

Problem

We don't have visibility into how long an individual background job is waiting for a semaphore permit.

Summary of changes

  • Make pageserver_background_loop_semaphore_wait_seconds a histogram rather than a sum.
  • Add a paced warning when a task takes more than 10 minutes to get a permit (for now).
  • Drive-by cleanup of some EnumMap usage.

@erikgrinaker erikgrinaker requested a review from skyzh February 6, 2025 15:05
@erikgrinaker erikgrinaker requested a review from a team as a code owner February 6, 2025 15:05
@erikgrinaker erikgrinaker force-pushed the erik/background-job-histogram branch from b596786 to f6f185b Compare February 6, 2025 15:10
@erikgrinaker erikgrinaker added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 2943590 Feb 6, 2025
92 checks passed
@erikgrinaker erikgrinaker deleted the erik/background-job-histogram branch February 6, 2025 17:25
Copy link

github-actions bot commented Feb 6, 2025

7425 tests run: 7071 passed, 0 failed, 354 skipped (full report)


Code coverage* (full report)

  • functions: 33.3% (8589 of 25823 functions)
  • lines: 49.1% (72294 of 147250 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
f6f185b at 2025-02-06T17:26:11.544Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants