Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storcon: deny external node configuration if an operation is ongoing #8727

Merged
merged 9 commits into from
Aug 15, 2024

Conversation

koivunej
Copy link
Member

@koivunej koivunej commented Aug 14, 2024

Per #8674, disallow node configuration while drain/fill are ongoing. Implement it by adding a only-http wrapper Service::external_node_configure which checks for operation existing before configuring.

Additionally:

  • allow cancelling drain/fill after a pageserver has restarted and transitioned to WarmingUp

Fixes: #8674

@koivunej koivunej requested a review from VladLazar August 14, 2024 15:21
@koivunej koivunej requested a review from a team as a code owner August 14, 2024 15:21
@koivunej koivunej changed the title storcon: disallow node configuration while operation is ongoing storcon: disallow external node configuration while operation is ongoing Aug 14, 2024
@koivunej koivunej changed the title storcon: disallow external node configuration while operation is ongoing storcon: disallow external node configuration if an operation is ongoing Aug 14, 2024
Copy link

github-actions bot commented Aug 14, 2024

2164 tests run: 2095 passed, 0 failed, 69 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_delete_timeline_client_hangup: release

Code coverage* (full report)

  • functions: 32.4% (7219 of 22266 functions)
  • lines: 50.4% (58287 of 115727 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0ee542f at 2024-08-15T09:59:50.707Z :recycle:

@koivunej koivunej changed the title storcon: disallow external node configuration if an operation is ongoing storcon: deny external node configuration if an operation is ongoing Aug 15, 2024
@koivunej koivunej enabled auto-merge (squash) August 15, 2024 08:32
@koivunej koivunej disabled auto-merge August 15, 2024 08:40
@koivunej koivunej enabled auto-merge (squash) August 15, 2024 09:22
@koivunej koivunej merged commit d9a57ae into main Aug 15, 2024
59 checks passed
@koivunej koivunej deleted the joonas/disallow_manual_policy_something branch August 15, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

controller: if pageserver restarts during drain, node can be left in PauseForRestart state
2 participants