-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storcon: deny external node configuration if an operation is ongoing #8727
Merged
+70
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
commented
Aug 14, 2024
koivunej
changed the title
storcon: disallow node configuration while operation is ongoing
storcon: disallow external node configuration while operation is ongoing
Aug 14, 2024
koivunej
changed the title
storcon: disallow external node configuration while operation is ongoing
storcon: disallow external node configuration if an operation is ongoing
Aug 14, 2024
koivunej
commented
Aug 14, 2024
VladLazar
reviewed
Aug 14, 2024
2164 tests run: 2095 passed, 0 failed, 69 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
0ee542f at 2024-08-15T09:59:50.707Z :recycle: |
koivunej
changed the title
storcon: disallow external node configuration if an operation is ongoing
storcon: deny external node configuration if an operation is ongoing
Aug 15, 2024
VladLazar
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #8674, disallow node configuration while drain/fill are ongoing. Implement it by adding a only-http wrapper
Service::external_node_configure
which checks for operation existing before configuring.Additionally:
Fixes: #8674