Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] fix: Properly show attachment extension #6676

Open
wants to merge 1 commit into
base: stable26
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 20, 2025

Backport of #6671

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the backport/6671/stable26 branch from 130aa5a to 3b4548e Compare January 20, 2025 14:08
@juliusknorr juliusknorr marked this pull request as ready for review January 20, 2025 14:08
Copy link

cypress bot commented Jan 20, 2025

Deck    Run #1963

Run Properties:  status check failed Failed #1963  •  git commit 10278d3732 ℹ️: Merge 3b4548e090cb59ee156d9f94adca844a3580ba44 into 0f3c0989a8147b3da24050b16bfe...
Project Deck
Branch Review backport/6671/stable26
Run status status check failed Failed #1963
Run duration 04m 27s
Commit git commit 10278d3732 ℹ️: Merge 3b4548e090cb59ee156d9f94adca844a3580ba44 into 0f3c0989a8147b3da24050b16bfe...
Committer backportbot[bot]
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 14
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/cardFeatures.js • 1 failed test

View Output

Test Artifacts
Card > Modal > Attachment from files app Screenshots

@luka-nextcloud
Copy link
Contributor

@juliusknorr Code change for cypress test is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants