Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Android 13 themed icon #170

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

sadorowo
Copy link

@sadorowo sadorowo commented Jun 9, 2024

Fixes #169

Previews:

non-themed themed
image image

How to enable themed icon:

Warning

These instructions are for AOSP-based ROMs only.

  1. Ensure you are on Android 13 or higher.
  2. Long hold empty space on your home screen and select 'Wallpapers & style'.
  3. Scroll down and enable 'Themed icons':
    image

sadorowo added 2 commits June 9, 2024 13:52
Signed-off-by: sadorowo <me@sador.me>
Signed-off-by: sadorowo <me@sador.me>
@binsky08 binsky08 added this to the v1.5.1 milestone Jun 9, 2024
@binsky08 binsky08 self-requested a review October 17, 2024 16:15
Copy link
Collaborator

@binsky08 binsky08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the pull requests. It looks good in general.

Adaptive icons are only supported from api level 26. Since passman-android currently also supports devices from api level 21, it still needs the legacy icon as a fallback.

I've the commits already locally, but I'm not allowed to edit this pr. So may I'll add them later or so. It's fine for now.

@sadorowo
Copy link
Author

Hi, thanks for the pull requests. It looks good in general.

Adaptive icons are only supported from api level 26. Since passman-android currently also supports devices from api level 21, it still needs the legacy icon as a fallback.

I've the commits already locally, but I'm not allowed to edit this pr. So may I'll add them later or so. It's fine for now.

Screenshot_20250118-214933

weird, maintainers can edit PRs

@binsky08
Copy link
Collaborator

binsky08 commented Jan 18, 2025

Hi, thanks for the pull requests. It looks good in general.
Adaptive icons are only supported from api level 26. Since passman-android currently also supports devices from api level 21, it still needs the legacy icon as a fallback.
I've the commits already locally, but I'm not allowed to edit this pr. So may I'll add them later or so. It's fine for now.

Screenshot_20250118-214933

weird, maintainers can edit PRs

yes, but I think I don't have the maintainer role

or I just failed somehow :D

@sadorowo
Copy link
Author

Hi, thanks for the pull requests. It looks good in general.
Adaptive icons are only supported from api level 26. Since passman-android currently also supports devices from api level 21, it still needs the legacy icon as a fallback.
I've the commits already locally, but I'm not allowed to edit this pr. So may I'll add them later or so. It's fine for now.

Screenshot_20250118-214933
weird, maintainers can edit PRs

yes, but I think I don't have the maintainer role

or I just failed somehow :D

i've added you as a collaborator on my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add themed icon
2 participants