Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

private/juliushaertl/cool settings iframe 2 #4446

Closed
wants to merge 33 commits into from
Closed

private/juliushaertl/cool settings iframe 2 #4446

wants to merge 33 commits into from

Conversation

juliusknorr
Copy link
Member

  • Initial cool admin setting iframe setup
  • WIP auth
  • Temp: Auth handling stuff
  • WIP: wopi setting upload
  • Created an AppData-based directory for system settings and user settings
  • Create a Settings controller API endpoint for handling AppData-based directories
  • Temporary Commit: Created a temporary UI to validate the functionality of user and system settings.
  • Change the admin settings iframe URL to adminIntegratorSettings.
  • WOPI: Update the wopi setting upload route to accept a file and store it to system-settings dir
  • add delete button and create wopi/setting route to handle wopi file request
  • Manage setting configs files with dynamic routes
  • Code cleanup: Remove POC helper functions
  • Send WOPI setting base URL to integrator
  • fix: fetch config url
  • wopi: add delete setting file route
  • refactor: token generation for iframe
  • feat(user-settings): introduce iframe for user settings
  • fix: linting issue for CI
  • fix: generate token for user shared config url
  • fix: accept document and setting url token for file upload
  • fix: set proper WOPI response and remove unnecessary WOPI callback from iframe
  • fix(settings): remove iframe title and section
  • fix(settings): fetch directory from root folder
  • fix(wopi): share SharedSettings to wopi checkfileInfo
  • fix(wopi): Generating setting token for guest users
  • fix(settings): generate user config per userId & handle guest users
  • fix: composer psalm error via pointing correct folder
  • fix: code cleanups
  • fix: move admin setting iframe below server-config
  • refactor: some code cleanups
  • config: support hasSettingIframeSupport capability
  • fix: Avoid warning on file id explode
  • ci: Keep separate assets for cypress
  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@codewithvk
Initial cool admin setting iframe setup
376c8eb 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
WIP auth
7cdc547 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
Temp: Auth handling stuff
29eb8a1 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
WIP: wopi setting upload
ee53126 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
Created an AppData-based directory for system settings and user settings
550f6bc 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
Create a Settings controller API endpoint for handling AppData-based …
f0f2871 
…directories

Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
Temporary Commit: Created a temporary UI to validate the functionalit…
6e60009 
…y of user and system settings.

Note: We will delete this commit/code after the entire prototype is ready. Reviewers can ignore this commit during the review process.
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
Change the admin settings iframe URL to adminIntegratorSettings.
7d93ddf 
TODO: We should try to centralize the path everywhere so that a change in one place updates it everywhere!
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
WOPI: Update the wopi setting upload route to accept a file and store…
64422c1 
… it to system-settings dir

Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
add delete button and create wopi/setting route to handle wopi file r…
e9549b7 
…equest

Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
Manage setting configs files with dynamic routes
346d2c0 
- Implement dynamic routing for settings files, enabling URLs structured as /settings/{type}/{category}/{filename}.
- Support various setting types (e.g. userconfigs, sharedconfigs) and categories (e.g. autotext, wordbook) so that multiple files can be stored for each category.
- Ensure proper URL parsing and directory handling for uploading and retrieving files via the WOPI interface.

Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
Code cleanup: Remove POC helper functions
d7639c5 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
Send WOPI setting base URL to integrator
a126ae0 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix: fetch config url
c1caefe 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
wopi: add delete setting file route
6d82912 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
refactor: token generation for iframe
b94a1bf 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
feat(user-settings): introduce iframe for user settings
0a17cf2 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix: linting issue for CI
97d83b1 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix: generate token for user shared config url
2aa7eef 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix: accept document and setting url token for file upload
478c976 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix: set proper WOPI response and remove unnecessary WOPI callback fr…
a6f49bb 
…om iframe

Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix(settings): remove iframe title and section
0ba4a68 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix(settings): fetch directory from root folder
41cfbf7 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix(wopi): share SharedSettings to wopi checkfileInfo
4326959 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix(wopi): Generating setting token for guest users
d87ff89 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix(settings): generate user config per userId & handle guest users
452f7c1 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix: composer psalm error via pointing correct folder
b2c5bad 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix: code cleanups
d589c57 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
fix: move admin setting iframe below server-config
e786703 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@codewithvk
refactor: some code cleanups
66c1253 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
codewithvk and others added 3 commits February 5, 2025 16:49
@codewithvk
config: support hasSettingIframeSupport capability
2bbca24 
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
@juliusknorr
fix: Avoid warning on file id explode
56a8c72 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr
ci: Keep separate assets for cypress
ebbebd0 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr juliusknorr mentioned this pull request Feb 5, 2025
Merged
@codewithvk
Copy link
Collaborator

We already merged the main PR - closing this now.

@codewithvk codewithvk closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elzody elzody Awaiting requested review from elzody elzody will be requested when the pull request is marked ready for review elzody is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusknorr @codewithvk