FeliCa: check for 212 kbit tag if no 424 kbit tags are found #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some FeliCa cards only respond to 212 kbit polling requests (for instance Hong Kong metro aka Octopus cards) so we should poll for them after checking for 424 kbit high-speed functionality Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
SloCompTech
reviewed
Jun 29, 2018
|
Yes has been tested |
smortex
reviewed
Jul 2, 2018
| if (candidates_count < 0) | ||
| return NULL; | ||
|
|
||
| // Poll for a FELICA 212 kbit tag (only if no 424 kbit tag was found) |
There was a problem hiding this comment.
Can't we list both 212 and 424 kbit tags instead of listing 212 tags when no 424 is found?
There was a problem hiding this comment.
Guess one could... but does libfreefare support multiple readers? If not then it doesn't make too much sense to worry about that use case
There was a problem hiding this comment.
I guess it does: as far as I can recall, I ran the test suite with 2 devices and 1 or 2 cards on each. Has less communication problems than with 1 device and 3+ tags 😄
But sometimes my memory tricks on me, and I don't have this hardware anymore to check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some FeliCa cards only respond to 212 kbit polling requests
(for instance Hong Kong metro aka Octopus cards) so we should poll
for them after checking for 424 kbit high-speed functionality
Signed-off-by: Matt Ranostay matt.ranostay@konsulko.com