Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

percentage_run_game #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brunomioto
Copy link

Based on @ChiefsAnalytics insights about the -new- Chiefs running game, I've done some charts with % of running plays in each game of 2019-2020 Chiefs season.

@guga31bb
Copy link
Member

Thank you for the submission!

  1. Please double-check your header stuff to make sure it looks like this post. For example, one part should look like:
output:
  distill::distill_article:
    self_contained: false
    toc: true
    toc_depth: 3

And another

knitr::opts_chunk$set(
  echo = TRUE, 
  message = FALSE, 
  warning = FALSE, 
  dpi = 300, 
  tidy = 'styler'
  )
  1. Please knit the .Rmd and push all the files associated with the post. There should be much more than 2 in the Files changed tab on top

@brunomioto
Copy link
Author

I don't think I've understood how to do it...
I have zero experience working with github :/
Just wanted to share some code and tried to follow the guidelines, but now I'm stuck.

@mrcaseb
Copy link
Member

mrcaseb commented Sep 15, 2020

There are multiple problems with this pull request most of them unrelated to github. I'll try in a few words:

  1. You don't make usage of RMarkdown as you didn't put your code in chunks. Therefore you are far away from a working blog post and should read the basics of distill and RMarkdown
  2. You are missing required metadata for open source football like mentioned here and in the sample file
  3. As soon as 1 and 2 are done and you knit your post you will find 10-20 new files related to your post you need to push to github.

When 1-3 are done we are able to check your post. I hope this was a little more clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants