-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: install apk #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also specify the reason for creating a new execBinaryAsync
function instead of reusing the execBinarySync
function in the description of the pull request (for documentation purposes)?
@garg3133 PR updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
Ah, sorry about changing the Putting it back in another commit. |
Description
This PR:
install
subcommand as shown below:execBinaryAsync
function instead of reusing the previously presentexecBinarySync
function. This was done because synchronous flow cannot catch the error thrown by theadb install
command.execBinaryAsync
function runs the command asynchronously allowing us to handle any possible errors.Screencast.from.29-07-24.03.06.52.PM.IST.webm