Merge pull request #41 from nimblehq/release/2.4.0

Release `eslint-config-nimble` 2.4.0 and `eslint-config-nimble-react` 1.1.0

.github/workflows/publish.yml

@@ -0,0 +1,32 @@
+name: Publish packages to npmjs
+
+on:
+  release:
+    types:
+      - published
+
+jobs:
+  publish:
+    name: Publish packages
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup node and restore cached dependencies
+        uses: actions/setup-node@v3
+        with:
+          node-version: "16.x"
+          cache: "npm"
+          registry-url: "https://registry.npmjs.org"
+          scope: "@nimblehq"
+
+      - name: Install dependencies
+        run: npm ci && lerna bootstrap --ci
+
+      - name: Publish packages to npmjs
+        run: npx lerna publish from-package --yes --no-verify-access
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

README.md

@@ -7,6 +7,7 @@
 The configurations are separated into dedicated packages:
 
 - [eslint-config-nimble](/packages/eslint-config-nimble): ESLint base rules
+- [eslint-config-nimble-react](/packages/eslint-config-nimble-react): ESLint rules for React
 
 __Usage information is in the packages' documentation.__
 
@@ -28,13 +29,11 @@ __Usage information is in the packages' documentation.__
 
 ### Publish packages
 
-Use [`lerna publish`](https://github.com/lerna/lerna/tree/main/commands/publish#readme) command to publish packages.
+- Packages will be published to npmjs automatically after publishing a new release.
 
-```bash
-  lerna publish
-```
+- Need to set the version in `/packages/**/package.json` before creating the release.
 
-_The current branch that you run the publish command should be pushed on Github._
+- More details in [publish workflow](/.github/workflows/publish.yml). This workflow uses [`lerna publish`](https://github.com/lerna/lerna/tree/main/commands/publish#readme) command to publish packages.
 
 ### Run commands
 

packages/eslint-config-nimble-react/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nimblehq/eslint-config-nimble-react",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "description": "ESLint React configuration developed and maintained by Nimble",
   "keywords": [
     "eslint",
@@ -19,11 +19,11 @@
     "lib"
   ],
   "dependencies": {
-    "@nimblehq/eslint-config-nimble": "^2.3.0",
+    "@nimblehq/eslint-config-nimble": "^2.4.0",
     "eslint": "^8.12.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-jsx-a11y": "^6.5.1",
-    "eslint-plugin-prettier": "^4.0.0",
+    "eslint-plugin-prettier": "^4.2.1",
     "eslint-plugin-react": "^7.29.4",
     "eslint-plugin-react-hooks": "^4.4.0",
     "eslint-plugin-testing-library": "^5.2.1"

packages/eslint-config-nimble/.eslintrc.js

@@ -1,5 +1,3 @@
 module.exports = {
-  extends: [
-    './lib/index.js',
-  ],
+  extends: ['./lib/index.js'],
 };

packages/eslint-config-nimble/lib/index.js

@@ -27,6 +27,7 @@ module.exports = {
     './rules/typescript',
     './rules/import',
     './rules/testing',
+    './rules/prettier', // prettiter must be the last one
   ].map(require.resolve),
   rules: {},
 };