Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add nullptr handling for NativeKeyObject #56900

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wooffie
Copy link
Contributor

@wooffie wooffie commented Feb 3, 2025

Fixes: #56899

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Feb 3, 2025
@wooffie wooffie changed the title src: Add nullptr handling for NativeKeyObject src: add nullptr handling for NativeKeyObject Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.16%. Comparing base (793c793) to head (f3212f6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_keys.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56900      +/-   ##
==========================================
- Coverage   89.17%   89.16%   -0.02%     
==========================================
  Files         665      665              
  Lines      192602   192603       +1     
  Branches    37058    37055       -3     
==========================================
- Hits       171748   171729      -19     
- Misses      13664    13671       +7     
- Partials     7190     7203      +13     
Files with missing lines Coverage Δ
src/crypto/crypto_keys.cc 72.13% <0.00%> (-0.10%) ⬇️

... and 24 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding handle for unwrap in 'src/crypto/crypto_keys.cc`
2 participants