Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 68.md with NIP-22 comments for replies #1689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alltheseas
Copy link
Contributor

added reference and link to NIP-22 comments for replies for kind 20 feeds

added reference and link to NIP-22  comments for replies
@vitorpamplona
Copy link
Collaborator

Ack

@kehiy
Copy link
Contributor

kehiy commented Jan 15, 2025

isn't that obvious? i think we need to talk about mentions reactions, replies, reposts, zaps, and more only in cases where someone needs to take different actions. what do you think?

@alltheseas
Copy link
Contributor Author

alltheseas commented Jan 15, 2025

isn't that obvious?

Pablo asked the same question.

Thinking through the lens of a new to nostr dev: is the expectation that a new dev needs to read all NIPs before coding an app?

Say the dev wants to build Instagram picture first app, and only reads NIP-68, and NIP-01. How does the dev know to add NIP-22 comments to a kind-20 feed?

@kehiy
Copy link
Contributor

kehiy commented Jan 15, 2025

How does the dev know to add NIP-22 comments to a kind-20 feed?

i may say we can expect them to check: is there any standard way to implement for example replies? then they check this repo for this.

but i agree that this would be easier. if we want to do this. my suggestion is to add a new section at the end of all nips and link them to this stuff. for example replies based on nip-22, it requires nip-x, and so on.

@alltheseas
Copy link
Contributor Author

@hzrd149 @alexgleason @fabianfabian what do yall think

68.md Outdated Show resolved Hide resolved
@fabianfabian
Copy link

@hzrd149 @alexgleason @fabianfabian what do yall think

I haven't followed all the discussion but I think we should use the same replies/comments kind for all root kinds (including root kind:1). I also think there should be a way to query for only roots or only replies, which NIP-22 seems to solve.

Right now Nostur is using kind:1 for all replies to any root kind. I would like to switch it to kind:1111 but NIP-22 mentions specifically "Comments MUST NOT be used to reply to kind 1 notes." so I'm probably missing the point somewhere. Is the idea to eventually migrate in the future or never?

@vitorpamplona
Copy link
Collaborator

I am migrating every reply to nip 22 on Amethyst. In time, that will also include kind 1.

Kind 1/NIP-10 markers should be deprecated in the future.

changed terminology "feeds" to "events"

Co-authored-by: hzrd149 <8001706+hzrd149@users.noreply.github.com>
@1l0
Copy link

1l0 commented Feb 2, 2025

@fabianfabian Welcome to the 1111 syndicate. My superior has fallen into the enemy's scheme, but we cannot afford to retreat from the front line.

@mikedilger
Copy link
Contributor

Boys, it's been a long hike through deep snow and you can see the hut right over the next rise. A lot of you are going to want to just run straight for it. But there are crevasses about. We're gonna need to hike around the long way.

What if you found that nobody ever replied to your posts anymore. You might think nostr is dying and go somewhere else. We need to avoid creating that situation for the users. I'd hate to "optimize" event loading, but lose 75% of the people on nostr who didn't understand why their client didn't work anymore.

@staab
Copy link
Member

staab commented Feb 3, 2025

We should keep nip 10 replies on kinds 1s forever.

@alltheseas
Copy link
Contributor Author

One recent piece of dev feedback I received - keeping track of all the changing specs is a pain in the backside.

@AsaiToshiya
Copy link
Collaborator

Can I delete BREAKING.md?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants