feat(api-service): polish attrs process #7477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
commented
Jan 9, 2025
| @@ -65,6 +85,10 @@ function processAttributes( | |||
| attrs[attr] as string, | |||
| attrs.fallback as string, | |||
| ); | |||
| if (!MAILY_FIRST_CITIZEN_VARIABLE_KEY.includes(flag)) { | |||
| // eslint-disable-next-line no-param-reassign | |||
| attrs[flag] = false; | |||
There was a problem hiding this comment.
this is the main change, the other changes are reuse enum
djabarovgeorge
commented
Jan 9, 2025
| @@ -65,6 +85,10 @@ function processAttributes( | |||
| attrs[attr] as string, | |||
| attrs.fallback as string, | |||
| ); | |||
| if (!MAILY_FIRST_CITIZEN_VARIABLE_KEY.includes(flag)) { | |||
There was a problem hiding this comment.
we do not want to update the id and idShowKey, because mainly hold the actual value in them and not the flag. as with other attributes.
so for example isUrlVariable=true/false is a flag, while id=payload.foo is a value.
SokratisVidros
approved these changes
Jan 10, 2025
LetItRock
reviewed
Jan 10, 2025
LetItRock
approved these changes
Jan 10, 2025
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer