-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.3 effect syntax #552
5.3 effect syntax #552
Conversation
I like the idea, if that sounds good to you I'll make it more aligned with our other migration specific extensions and add tests to turn it into a full PR. |
Feel free to take it from there. |
ebfe4ff
to
09c44f7
Compare
I added a test and tweaked a couple simple things. I still have a couple concerns though before we can merge this:
I'll test this a bit more. If it turns out I was right, I think we could add a flag to the driver to force it to migrate the AST and use the compiler's printer to prevent that from happening in the few places where it could cause troubles. |
a72b543
to
bdbe1dc
Compare
bdbe1dc
to
78725b1
Compare
341c175
to
6825170
Compare
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
6825170
to
43de589
Compare
No description provided.