Fix FutureWarnings #57
Conversation
demandlib had some pandas warnings: FutureWarning: Downcasting object dtype arrays on .fillna, .ffill, .bfill is deprecated and will change in a future version FutureWarning: Setting an item of incompatible dtype is deprecated and will raise in a future error of pandas FutureWarning: A value is trying to be set on a copy of a DataFrame or Series through chained assignment using an inplace method These are fixed through this commit
src/demandlib/bdew/elec_slp.py
Outdated
| tmp_df["hour_of_day"] = tmp_df.index.hour.astype(float) | ||
| tmp_df["minute_of_hour"] = tmp_df.index.minute.astype(float) |
There was a problem hiding this comment.
Shouldn't it make sense to preserve the integers, here?
| tmp_df["hour_of_day"] = tmp_df.index.hour.astype(float) | |
| tmp_df["minute_of_hour"] = tmp_df.index.minute.astype(float) | |
| tmp_df["hour_of_day"] = tmp_df.index.hour.astype(int) | |
| tmp_df["minute_of_hour"] = tmp_df.index.minute.astype(int) |
There was a problem hiding this comment.
tmp_df.index.hour is already int - we need to adjust this in L117 and L119 and remove it in L124 and L125.
Will do
|
Hi @maurerle, thanks for your fixes (and sorry for letting this uncommented for such a long time). I just realised that demandlib needs some love (to have a maintenance release) and so I am very happy that you cared for some of the changes needed to maintain compatibility. If you like, don't forget to add your name to the list of authors. |
|
Hello @maurerle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
To Reproduce
The following snippet produces warnings using python 3.11 and pandas 2.2.1
demandlib had some pandas warnings:
FutureWarning: Downcasting object dtype arrays on .fillna, .ffill, .bfill is deprecated and will change in a future versionFutureWarning: Setting an item of incompatible dtype is deprecated and will raise in a future error of pandasFutureWarning: A value is trying to be set on a copy of a DataFrame or Series through chained assignment using an inplace methodThese are fixed through this commit.