Handle overflow in File Preview

[DonXavierdev]

Proposed Changes

• Fixes File Preview Box Overflows #10122
• Add max height to limit vertical overflow
• Add padding for better spacing

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• Style
  • Improved file upload dialog layout with increased vertical spacing
  • Added scrollable content area for file upload dialog with maximum height

[coderabbitai]

Walkthrough

The pull request modifies the FileUploadDialog component in src/components/Files/FilesTab.tsx to address file preview dialog overflow issues. The changes update the <div> element's class to improve vertical spacing, add a maximum height, and implement overflow scrolling. This enhancement ensures that when multiple files are uploaded, the dialog remains usable by preventing vertical overflow and providing a scrollable interface.

Changes

File	Change Summary
src/components/Files/FilesTab.tsx	Updated div class from space-y-4 to space-y-6 pr-5 max-h-[70vh] overflow-y-auto to improve layout and scrolling

Assessment against linked issues

Objective	Addressed	Explanation
Prevent file preview box overflow [#10122]	✅
Add scrollbar for multiple files [#10122]	✅

Possibly related PRs

• Fix FileUploadDialog overflow | Use ShadCN component #10047: Modifies FileUploadDialog component with similar layout improvements
• Fix Actions-section responsiveness #10072: Affects FilesTab component's responsiveness

Suggested labels

tested, needs review

Suggested reviewers

• Jacobjeevan
• rithviknishad

Poem

🐰 Scrolling files, no more despair,
Rabbit's fix with tender care,
Vertical space now neat and clean,
Upload dialog, a scrolling scene!
Overflow banished, users cheer! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	6b87ab4
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/679332a4166d570008396117
😎 Deploy Preview	https://deploy-preview-10133--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Files/FilesTab.tsx (1)

588-588: Consider using responsive breakpoints for better user experience on smaller screens.

Adding max-h-[70vh] along with vertical scrolling effectively addresses overflow concerns. However, for very small devices, 70% of the viewport may still exceed the screen space. Consider implementing alternative heights for smaller breakpoints (e.g., max-h-[60vh] md:max-h-[70vh]) or improving horizontal scroll behavior if needed.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 923423f and 6b87ab4.

📒 Files selected for processing (1)

• src/components/Files/FilesTab.tsx (1 hunks)

🧰 Additional context used

📓 Learnings (1)

src/components/Files/FilesTab.tsx (1)

Learnt from: rajku-dev
PR: ohcnetwork/care_fe#10047
File: src/components/Files/FilesTab.tsx:580-580
Timestamp: 2025-01-20T09:46:46.025Z
Learning: In FileUploadDialog, using `max-w-fit` on the dialog content is acceptable when the internal content (like filenames) is already constrained with classes like `max-w-xs` and `truncate`.