Fix: Current Day is greyed out in Appointments calendar #10311

AdityaJ2305 · 2025-01-30T21:24:07Z

Proposed Changes

Fixes Current Day is greyed out in Appointments calendar #10304
Change 1
Change 2
More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Bug Fixes
- Improved date selection logic in appointment slot picker
- Enabled button interactions for the current date
- Enhanced user experience by dynamically managing button states based on date conditions

coderabbitai · 2025-01-30T21:24:15Z

Walkthrough

The pull request modifies the AppointmentSlotPicker.tsx component to improve the interaction with the current date in the appointments calendar. A new variable isToday is introduced to check if the rendered date matches the current date. This change allows the button to be enabled for the current date, addressing the issue of the current date being greyed out and uninteractive.

Changes

File	Change Summary
`src/pages/Appointments/components/AppointmentSlotPicker.tsx`	Added `isToday` variable to conditionally enable button for current date

Assessment against linked issues

Objective	Addressed	Explanation
Current date should be non-greyed [#10304]	✅

Possibly related PRs

Resolved the unwanted hover effect and the text colour remains constant #10120: Modifies rendering logic in AppointmentSlotPicker.tsx
Fix Layout Overflow on Appointment and Patient Details Pages for Mobile Screens #10267: Addresses layout overflow in AppointmentsPage.tsx

Suggested labels

needs testing, needs review

Suggested reviewers

rithviknishad

Poem

🐰 A calendar's tale of today's delight,
Where buttons once grey now shine so bright!
No more disabled, the current day gleams,
Appointments flow like magical streams.
A rabbit's code, with wisdom so clear,
Brings interaction we all hold dear! 🗓️

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b321c06 and 6d5ca1f.

📒 Files selected for processing (1)

src/pages/Appointments/components/AppointmentSlotPicker.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/pages/Appointments/components/AppointmentSlotPicker.tsx

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: cypress-run (1)
GitHub Check: OSSAR-Scan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-30T21:24:28Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`f6f4798`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/679bf41863da720008e07aab
😎 Deploy Preview	https://deploy-preview-10311--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 1

🔭 Outside diff range comments (1)

src/pages/Appointments/components/AppointmentSlotPicker.tsx (1)
Line range hint 64-85: Address inconsistent handling of today's date across renderDay conditions.

The special handling for today's date is only implemented in the first condition block (when there are no slots or during loading). The second block (when slots are available) doesn't have similar handling, which could lead to inconsistent behavior when slots become available during the current day.

Consider harmonizing the treatment of today's date across both rendering conditions.
       <button
-        disabled={isBeforeToday || isFullyBooked}
+        disabled={(isBeforeToday && !isToday) || isFullyBooked}
         onClick={() => {
Also applies to: 87-120

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 81a6257 and b321c06.

📒 Files selected for processing (1)

src/pages/Appointments/components/AppointmentSlotPicker.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

🔇 Additional comments (1)

src/pages/Appointments/components/AppointmentSlotPicker.tsx (1)

72-72: Verify disabled state behavior for edge cases.

The current implementation enables the button only for today's date. Please verify:

The button remains disabled for past dates

The button is correctly enabled for today even when there are no available slots

The behavior aligns with business requirements for allowing slot selection on the current day

src/pages/Appointments/components/AppointmentSlotPicker.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

…05/care_fe into current_day_greyed_out

rithviknishad · 2025-01-31T00:39:42Z

that return block is meant to be shown for disabled state only

add isToday

b321c06

AdityaJ2305 requested a review from a team as a code owner January 30, 2025 21:24

coderabbitai bot reviewed Jan 30, 2025

View reviewed changes

src/pages/Appointments/components/AppointmentSlotPicker.tsx Outdated Show resolved Hide resolved

AdityaJ2305 and others added 3 commits January 31, 2025 02:59

Update to isSamDay

6d5ca1f

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Empty-Commit

f5ae0f9

Merge branch 'current_day_greyed_out' of https://github.com/AdityaJ23…

f6f4798

…05/care_fe into current_day_greyed_out

rithviknishad closed this Jan 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Current Day is greyed out in Appointments calendar #10311

Fix: Current Day is greyed out in Appointments calendar #10311

AdityaJ2305 commented Jan 30, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 30, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 30, 2025 •

edited

Loading

coderabbitai bot left a comment

rithviknishad commented Jan 31, 2025

Fix: Current Day is greyed out in Appointments calendar #10311

Fix: Current Day is greyed out in Appointments calendar #10311

Conversation

AdityaJ2305 commented Jan 30, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Jan 30, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 30, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

rithviknishad commented Jan 31, 2025

AdityaJ2305 commented Jan 30, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 30, 2025 •

edited

Loading