Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Deprecated request #10352

Merged
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
70a6e2f
login file
AdityaJ2305 Feb 1, 2025
b397b5f
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 1, 2025
b7d491d
replace request with callApi and other utilities
AdityaJ2305 Feb 1, 2025
04c5b6d
Merge branch 'replace_deprecated_request' of https://github.com/Adity…
AdityaJ2305 Feb 1, 2025
655baff
discard changes in ResourceDetailsUpdate
AdityaJ2305 Feb 1, 2025
841d281
rm loading state from resource create
AdityaJ2305 Feb 1, 2025
a23757d
rm deprecated request
AdityaJ2305 Feb 1, 2025
c953fd3
coderabbit suggestion
AdityaJ2305 Feb 1, 2025
98d1c2b
grammatical mistake
AdityaJ2305 Feb 1, 2025
f126b19
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 2, 2025
a9cba8d
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 2, 2025
e15a5f0
replace callApi with mutate
AdityaJ2305 Feb 3, 2025
792ec55
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 3, 2025
a7ce09b
pending replacement done
AdityaJ2305 Feb 3, 2025
aa77424
coderabbit suggestion
AdityaJ2305 Feb 3, 2025
e3308bf
Empty-Commit
AdityaJ2305 Feb 3, 2025
81a2d69
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 3, 2025
379ade1
discard ResourcesCommentSection
AdityaJ2305 Feb 4, 2025
c18701d
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 4, 2025
e85a729
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 4, 2025
f815c08
pushed minor requested changes in all files
AdityaJ2305 Feb 4, 2025
ed71024
update Tbody to void
AdityaJ2305 Feb 4, 2025
abfc13e
userAvatar changes made
AdityaJ2305 Feb 4, 2025
a2561ff
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 4, 2025
e940d60
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 4, 2025
0dd7c25
Auth user changes done
AdityaJ2305 Feb 4, 2025
c11c6c4
Merge branch 'replace_deprecated_request' of https://github.com/Adity…
AdityaJ2305 Feb 4, 2025
d28c5a5
update queryKey for refresh
AdityaJ2305 Feb 4, 2025
d255752
pushed changes requested again
AdityaJ2305 Feb 4, 2025
0dc3cb2
sort locale
AdityaJ2305 Feb 4, 2025
88a28b1
put refreshtoken in useeffect
AdityaJ2305 Feb 4, 2025
9f4e3a5
update to use mutateAsync directly
AdityaJ2305 Feb 4, 2025
3ba6ac9
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 4, 2025
b1f0e1b
Merge remote-tracking branch 'upstream/develop' into replace_deprecat…
rithviknishad Feb 5, 2025
4d1cb74
fixes re-render issues due to improper memoization in AuthUserProvider
rithviknishad Feb 5, 2025
390f51d
cleanup and fix issues
rithviknishad Feb 5, 2025
6c9adaf
remove unused keys
rithviknishad Feb 5, 2025
58e6c48
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 5, 2025
0aba97b
resolved conflicts
AdityaJ2305 Feb 5, 2025
3487e9f
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 5, 2025
7c8ddc4
Merge remote-tracking branch 'upstream/develop' into replace_deprecat…
rithviknishad Feb 6, 2025
28adf66
fix patient login otp notification silenced
rithviknishad Feb 6, 2025
30f8c2b
fix profile pic invalidation
rithviknishad Feb 6, 2025
f02c332
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 6, 2025
51d23ed
Merge branch 'develop' into replace_deprecated_request
AdityaJ2305 Feb 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions public/locale/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,7 @@
"delete_record": "Delete Record",
"deleted_successfully": "{{name}} deleted successfully",
"deleting": "Deleting...",
"deletion_failed": "Failed to delete {{name}}",
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved
"demography": "Demography",
"denied_on": "Denied On",
"departments": "Departments",
Expand Down
36 changes: 19 additions & 17 deletions src/Providers/AuthUserProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ import { AuthUserContext } from "@/hooks/useAuthUser";
import { LocalStorageKeys } from "@/common/constants";

import routes from "@/Utils/request/api";
import query from "@/Utils/request/query";
import request from "@/Utils/request/request";
import query, { callApi } from "@/Utils/request/query";
import { TokenData } from "@/types/auth/otpToken";

interface Props {
Expand Down Expand Up @@ -56,12 +55,12 @@ export default function AuthUserProvider({

const signIn = useCallback(
async (creds: { username: string; password: string }) => {
const query = await request(routes.login, { body: creds });
const data = await callApi(routes.login, { body: creds });
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved

if (query.res?.ok && query.data) {
setAccessToken(query.data.access);
localStorage.setItem(LocalStorageKeys.accessToken, query.data.access);
localStorage.setItem(LocalStorageKeys.refreshToken, query.data.refresh);
if (data?.access && data?.refresh) {
setAccessToken(data.access);
localStorage.setItem(LocalStorageKeys.accessToken, data.access);
localStorage.setItem(LocalStorageKeys.refreshToken, data.refresh);

await queryClient.invalidateQueries({ queryKey: ["currentUser"] });

Expand All @@ -70,7 +69,7 @@ export default function AuthUserProvider({
}
}

return query;
return data;
},
[queryClient],
);
Expand Down Expand Up @@ -155,19 +154,22 @@ const updateRefreshToken = async (silent = false) => {
return;
}

const { res, data } = await request(routes.token_refresh, {
body: { refresh },
silent,
});
try {
const data = await callApi(routes.token_refresh, {
body: { refresh },
silent,
});

if (!data) {
throw new Error("Token refresh failed");
}

if (res?.status !== 200 || !data) {
localStorage.setItem(LocalStorageKeys.accessToken, data.access);
localStorage.setItem(LocalStorageKeys.refreshToken, data.refresh);
} catch {
localStorage.removeItem(LocalStorageKeys.accessToken);
localStorage.removeItem(LocalStorageKeys.refreshToken);
return;
}

localStorage.setItem(LocalStorageKeys.accessToken, data.access);
localStorage.setItem(LocalStorageKeys.refreshToken, data.refresh);
};
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved

const getRedirectURL = () => {
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/request/query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import { ApiCallOptions, ApiRoute, HTTPError } from "@/Utils/request/types";
import { makeHeaders, makeUrl } from "@/Utils/request/utils";
import { sleep } from "@/Utils/utils";

export type ApiResponse<TData> = TData;
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved

export async function callApi<Route extends ApiRoute<unknown, unknown>>(
{ path, method, noAuth }: Route,
options?: ApiCallOptions<Route>,
Expand Down
15 changes: 4 additions & 11 deletions src/components/Auth/Login.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ import FiltersCache from "@/Utils/FiltersCache";
import ViewCache from "@/Utils/ViewCache";
import routes from "@/Utils/request/api";
import mutate from "@/Utils/request/mutate";
import request from "@/Utils/request/request";
import { TokenData } from "@/types/auth/otpToken";

interface LoginFormData {
Expand Down Expand Up @@ -103,20 +102,14 @@ const Login = (props: LoginProps) => {
FiltersCache.invaldiateAll();
return await signIn(data);
},
onSuccess: ({ res }) => {
setCaptcha(res?.status === 429);
onSuccess: (res) => {
setCaptcha(!!res?.access);
},
});

// Send OTP Mutation
const { mutate: sendOtp, isPending: sendOtpPending } = useMutation({
mutationFn: async (phone: string) => {
const response = await request(routes.otp.sendOtp, {
body: { phone_number: phone },
silent: true,
});
return response;
},
mutationFn: mutate(routes.otp.sendOtp),
onSuccess: () => {
setIsOtpSent(true);
setOtpError("");
Expand Down Expand Up @@ -280,7 +273,7 @@ const Login = (props: LoginProps) => {

try {
if (!isOtpSent) {
await sendOtp(phone);
await sendOtp({ phone_number: phone });
setIsOtpSent(true);
} else {
await verifyOtp({ phone_number: phone, otp });
Expand Down
53 changes: 26 additions & 27 deletions src/components/Auth/ResetPassword.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { useMutation, useQuery } from "@tanstack/react-query";
import { navigate } from "raviger";
import { useEffect, useState } from "react";
import { useState } from "react";
import { useTranslation } from "react-i18next";
import { toast } from "sonner";

Expand All @@ -12,7 +13,8 @@ import { LocalStorageKeys } from "@/common/constants";
import { validatePassword } from "@/common/validation";

import routes from "@/Utils/request/api";
import request from "@/Utils/request/request";
import mutate from "@/Utils/request/mutate";
import query from "@/Utils/request/query";

interface ResetPasswordProps {
token: string;
Expand Down Expand Up @@ -69,40 +71,37 @@ const ResetPassword = (props: ResetPasswordProps) => {
}
return form;
};
const { mutate: resetPassword } = useMutation({
mutationFn: mutate(routes.resetPassword),
onSuccess: (_data) => {
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved
localStorage.removeItem(LocalStorageKeys.accessToken);
toast.success(t("password_reset_success"));
navigate("/login");
},
onError: (error) => {
if (error.cause) {
setErrors(error.cause);
}
},
});

const handleSubmit = async (e: any) => {
e.preventDefault();
const valid = validateData();
if (valid) {
valid.token = props.token;
const { res, error } = await request(routes.resetPassword, {
body: { ...valid },
});
if (res?.ok) {
localStorage.removeItem(LocalStorageKeys.accessToken);
toast.success(t("password_reset_success"));
navigate("/login");
} else if (res && error) {
setErrors(error);
}
resetPassword(valid);
}
};

useEffect(() => {
const checkResetToken = async () => {
const { res } = await request(routes.checkResetToken, {
body: { token: props.token },
});
if (!res || !res.ok) {
navigate("/invalid-reset");
}
};
if (props.token) {
checkResetToken();
} else {
navigate("/invalid-reset");
}
}, []);
const { isError } = useQuery({
queryKey: ["checkResetToken", { token: props.token }],
queryFn: () =>
query(routes.checkResetToken, { body: { token: props.token } }),
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved
enabled: !!props.token,
});

if (isError) navigate("/invalid-reset");
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved

return (
<div className="min-h-screen flex items-center justify-center bg-gray-100">
Expand Down
45 changes: 24 additions & 21 deletions src/components/Facility/FacilityHome.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
TooltipTrigger,
} from "@radix-ui/react-tooltip";
import { useQuery, useQueryClient } from "@tanstack/react-query";
import { useMutation } from "@tanstack/react-query";
import { Hospital, MapPin, MoreVertical, Settings } from "lucide-react";
import { navigate } from "raviger";
import { useState } from "react";
Expand Down Expand Up @@ -33,8 +34,8 @@ import { FACILITY_FEATURE_TYPES } from "@/common/constants";

import { PLUGIN_Component } from "@/PluginEngine";
import routes from "@/Utils/request/api";
import query from "@/Utils/request/query";
import request from "@/Utils/request/request";
import mutate from "@/Utils/request/mutate";
import query, { callApi } from "@/Utils/request/query";
import uploadFile from "@/Utils/request/uploadFile";
import { getAuthorizationHeader } from "@/Utils/request/utils";
import { sleep } from "@/Utils/utils";
Expand Down Expand Up @@ -105,23 +106,24 @@ export const FacilityHome = ({ facilityId }: Props) => {
pathParams: { id: facilityId },
}),
});
const { mutate: deleteFacility } = useMutation({
mutationFn: () =>
mutate(routes.deleteFacility, { pathParams: { id: facilityId } })(null),
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved
onSuccess: () => {
toast.success(t("deleted_successfully", { name: facilityData?.name }));
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved
navigate("/facility");
},
onError: () => {
toast.error(t("delete_failed", { name: facilityData?.name }));
},
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved
});

const handleDeleteClose = () => {
setOpenDeleteDialog(false);
const handleDeleteSubmit = () => {
deleteFacility();
};

const handleDeleteSubmit = async () => {
await request(routes.deleteFacility, {
pathParams: { id: facilityId },
onResponse: ({ res }) => {
if (res?.ok) {
toast.success(
t("deleted_successfully", { name: facilityData?.name }),
);
}
navigate("/facility");
},
});
const handleDeleteClose = () => {
setOpenDeleteDialog(false);
};
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved

const handleCoverImageUpload = async (file: File, onError: () => void) => {
Expand Down Expand Up @@ -154,16 +156,17 @@ export const FacilityHome = ({ facilityId }: Props) => {
};

const handleCoverImageDelete = async (onError: () => void) => {
const { res } = await request(routes.deleteFacilityCoverImage, {
pathParams: { id: facilityId },
});
if (res?.ok) {
try {
await callApi(routes.deleteFacilityCoverImage, {
pathParams: { id: facilityId },
});

AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved
toast.success(t("cover_image_deleted"));
queryClient.invalidateQueries({
queryKey: ["facility", facilityId],
});
setEditCoverImage(false);
} else {
} catch {
onError();
}
};
Expand Down
18 changes: 9 additions & 9 deletions src/components/Resource/ResourceCommentSection.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { useMutation } from "@tanstack/react-query";
import { t } from "i18next";
import { useState } from "react";
import { toast } from "sonner";
Expand All @@ -11,13 +12,18 @@ import { Avatar } from "@/components/Common/Avatar";
import CircularProgress from "@/components/Common/CircularProgress";

import routes from "@/Utils/request/api";
import request from "@/Utils/request/request";
import mutate from "@/Utils/request/mutate";
import { formatName, relativeTime } from "@/Utils/utils";
import { CommentModel } from "@/types/resourceRequest/resourceRequest";

const CommentSection = (props: { id: string }) => {
const [commentBox, setCommentBox] = useState("");

const { mutate: addResourceComments } = useMutation({
mutationFn: mutate(routes.addResourceComments, {
pathParams: { id: props.id },
}),
onSuccess: () => toast.success(t("comment_added_successfully")),
});
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved
const onSubmitComment = async () => {
const payload = {
comment: commentBox,
Expand All @@ -26,13 +32,7 @@ const CommentSection = (props: { id: string }) => {
toast.error(t("comment_min_length"));
return;
}
const { res } = await request(routes.addResourceComments, {
pathParams: { id: props.id },
body: payload,
});
if (res?.ok) {
toast.success(t("comment_added_successfully"));
}
addResourceComments(payload);
setCommentBox("");
};
return (
Expand Down
Loading
Loading