Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding nekolight theme (a starship variant) #655

Merged
merged 29 commits into from
Jan 27, 2025
Merged

feat: adding nekolight theme (a starship variant) #655

merged 29 commits into from
Jan 27, 2025

Conversation

BrunoCiccarino
Copy link
Contributor

adding a theme designed to be light, low-detail, minimalist, a variant of starship.

@BrunoCiccarino
Copy link
Contributor Author

I still have to add more things, calm down

@akinomyoga akinomyoga marked this pull request as draft January 26, 2025 05:49
@akinomyoga
Copy link
Contributor

Please be aware that an email is sent to me every time you push. You should open a PR when it is ready to be reviewed. Or please make the PR in a draft state.

@BrunoCiccarino
Copy link
Contributor Author

Please be aware that an email is sent to me every time you push. You should open a PR when it is ready to be reviewed. Or please make the PR in a draft state.

sorry, I hadn't thought about that, next time I hope to be ready, I just finished the pr

@akinomyoga
Copy link
Contributor

I just finished the pr

Do you mean this PR is ready? I turned this into a draft PR thirty minutes ago. If it is ready, please turn this PR back to a normal PR by pressing the button "[Ready for review]" at the bottom of this page.

@BrunoCiccarino BrunoCiccarino marked this pull request as ready for review January 26, 2025 06:23
akinomyoga
akinomyoga requested changes Jan 26, 2025
View reviewed changes
themes/nekolight/nekolight-light.jpg Outdated Show resolved Hide resolved
themes/nekolight/nekolight.theme.sh Outdated Show resolved Hide resolved
themes/nekolight/nekolight.theme.sh Outdated Show resolved Hide resolved
themes/nekolight/nekolight.theme.sh Outdated Show resolved Hide resolved
themes/nekolight/nekolight.theme.sh Outdated Show resolved Hide resolved
themes/nekolight/nekolight.theme.sh Outdated Show resolved Hide resolved
akinomyoga
akinomyoga requested changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is the second round.

themes/nekolight/nekolight.theme.sh Outdated Show resolved Hide resolved
themes/nekolight/nekolight.theme.sh Outdated Show resolved Hide resolved
akinomyoga
akinomyoga requested changes Jan 26, 2025
View reviewed changes
themes/nekolight/nekolight.theme.sh Outdated Show resolved Hide resolved
themes/nekolight/nekolight.theme.sh Outdated Show resolved Hide resolved
themes/nekolight/nekolight.theme.sh Outdated Show resolved Hide resolved
@akinomyoga
Copy link
Contributor

This is unrelated to the PR content, but in case you might not know, the gerund form of "fix" in English is "fixing".

@BrunoCiccarino
Copy link
Contributor Author

This is unrelated to the PR content, but in case you might not know, the gerund form of "fix" in English is "fixing".

My English is very bad, in schools here in Brazil the teaching of English is very poor

@akinomyoga
Copy link
Contributor

My English is very bad, in schools here in Brazil the teaching of English is very poor

That's not a bad thing. Also, I'd say English education in Japan is even worse. I just wanted to tell you that you could improve it. If you like "fixxing", you can actually continue to use "fixxing".

@BrunoCiccarino
Copy link
Contributor Author

My English is very bad, in schools here in Brazil the teaching of English is very poor

That's not a bad thing. Also, I'd say English education in Japan is even worse. I just wanted to tell you that you could improve it. If you like "fixxing", you can actually continue to use "fixxing".

No, it's definitely better to improve my English, it's a good language to start with

akinomyoga
akinomyoga reviewed Jan 26, 2025
View reviewed changes
themes/nekolight/README.md Outdated Show resolved Hide resolved
themes/nekolight/README.md Outdated Show resolved Hide resolved
themes/nekolight/nekolight-dark.jpg Outdated Show resolved Hide resolved
BrunoCiccarino and others added 3 commits January 26, 2025 20:41
@BrunoCiccarino @akinomyoga
Update themes/nekolight/README.md
59924d6 
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
@BrunoCiccarino
fix: fixxing image scale
1f6b609
@BrunoCiccarino @akinomyoga
Update themes/nekolight/README.md
73addfd 
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
akinomyoga
akinomyoga previously approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll later merge.

@BrunoCiccarino
Copy link
Contributor Author

Looks good. I'll later merge.

Ok, thanks bro

akinomyoga
akinomyoga previously approved these changes Jan 27, 2025
View reviewed changes
@akinomyoga akinomyoga merged commit e740d2a into ohmybash:master Jan 27, 2025
4 checks passed
@akinomyoga
Copy link
Contributor

Thanks! I merged it.

@BrunoCiccarino
Copy link
Contributor Author

Thanks! I merged it.

thank you bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinomyoga akinomyoga akinomyoga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoCiccarino @akinomyoga