Add API logging to validation layer #270
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
through validation layer. This will enable us to remove logging L0 calls from UR and make sure that all L0 calls are being logged (e.g. ones from UMF). Signed-off-by: Igor Chorazewicz <igor.chorazewicz@intel.com>
Signed-off-by: Igor Chorazewicz <igor.chorazewicz@intel.com>
with a single variable. Use getenv_to_map to implement env var parsing. Signed-off-by: Igor Chorazewicz <igor.chorazewicz@intel.com>
igchor
commented
Feb 4, 2025
| @@ -15,6 +15,53 @@ namespace validation_layer | |||
| { | |||
| context_t& context = context_t::getInstance(); | |||
|
|
|||
| void context_t::initLogger() try { | |||
| std::string loggingLevel = "error"; | |||
| std::string loggingFormat = "ZE ---> %v"; | |||
There was a problem hiding this comment.
Should we use the same default format as ze loader here? ([date] [logger_name] [level] message...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.