Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Proposal: Achievements API #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Mar 7, 2018

No description provided.

Copy link
Collaborator

@TalAmuyal TalAmuyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't goals be completable as well?

src/index.ts Outdated
goals: AchievementGoalDefinition[]
}

export interface AchievementGoalDefinition {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since AchievementDefinition and AchievementGoalDefinition are under Achievement, I think that the common prefix can be safely omitted.
Also, both end with Definition which is redundant too.
How about Definition and goal respectively?

Copy link
Member Author

@bryphe bryphe Mar 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ya, good catch - I like that better for sure! Updating now.

@TalAmuyal
Copy link
Collaborator

Trying my power as a reviewer 🙃

@bryphe
Copy link
Member Author

bryphe commented Mar 20, 2018

Thanks for looking at it, @TalAmuyal ! 👍

Copy link
Collaborator

@TalAmuyal TalAmuyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants