-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Proposal: Achievements API #30
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't goals be completable as well?
src/index.ts
Outdated
goals: AchievementGoalDefinition[] | ||
} | ||
|
||
export interface AchievementGoalDefinition { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since AchievementDefinition
and AchievementGoalDefinition
are under Achievement
, I think that the common prefix can be safely omitted.
Also, both end with Definition
which is redundant too.
How about Definition
and goal
respectively?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ya, good catch - I like that better for sure! Updating now.
Trying my power as a reviewer 🙃 |
Thanks for looking at it, @TalAmuyal ! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great :)
No description provided.