Make workspace save not blocking #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
This PR implements a long standing TODO that came back at us, file saving dialogs were blocking instead of async (like the loading ones).
This froze the background app in Linux / Windows which is a minor annoyance but completely froze the app in Mac which is a deal breaker.
Implementation description
This PR updates rfd as a precursor for
wasmsave support (a newTODOdocuments what would be necessary to get the feature in), makes file save dialogs run in a task pool, as well as remove dead code and refactor theSaveplugin inside theWorkspaceplugin, so now theWorkspaceplugin includes all workspace related functions (saving, creating and loading).Something similar will have to be done for the
Browsewindow when creating new models, but I left that out of this implementation for now to avoid making the complexity explode.