Early support for undo in ChangePlugin
#257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a POC version of undo for the `ChangePlugin`. We still have to implement undo for movement, adding and deleteing items. One thing to note is that the current architecture assumes a change at the individual component level. Also currently, we need `ResMut` access tot he undo buffer from all change plugins. There may come a time where we may want to change multiple components in a single operation. Signed-off-by: Arjo Chakravarty <arjoc@google.com>
1 task
arjo129
commented
Dec 27, 2024
rmf_site_editor/src/site/mod.rs
Outdated
| @@ -212,6 +215,7 @@ impl Plugin for SitePlugin { | |||
| ChangePlugin::<Scale>::default(), | |||
| ChangePlugin::<Distance>::default(), | |||
| ChangePlugin::<Texture>::default(), | |||
| UndoPlugin::default() | |||
There was a problem hiding this comment.
TODO: Move to lib.rs in case we want to run in headless mode
1 task
1 task
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
…st' into arjo/feat/undo_latest
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
…st' into arjo/feat/undo_latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
This provides a POC version of undo for the
ChangePlugin. We still have to implement undo for movement, adding and deleteing items. One thing to note is that the current architecture assumes a change at the individual component level. Also currently, we needResMutaccess tot he undo buffer from all change plugins. There may come a time where we may want to change multiple components in a single operation. PerhapsChangeshould be something thatTODO
Implementation description