-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the inner bundle of Parented transparent #264
Conversation
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
@mxgrey Thank you for taking a look at this! I experimented with it previously and the issue with flattening the Bundle content is that the fields of the bundle will be stored as strings with
Adding a valid format (
|
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Whoops, I hadn't thought of running all the unit tests before opening this PR since I thought it would be a trivial change. Thanks for helping me understand why the RON roundtrip test was failing. I fell into a bit of a rabbit hole with ron-rs/ron#548 and then ron-rs/ron#555 but it seems everything is working now. For this to work we'll need to target the github repo of RON until its next release, but I think RON will probably have a new release well before we do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for hunting down the solution, tried out with the demo map and it works great! ✨ The error remains if we add anything to optional_model_properties
, i.e. Tasks
which would also require serde(transparent)
for loading to work. However these struct are pending some refactor in #263 so I'm happy to give an approval first.
A small tweak to how to things nested inside of
Parented
get serialized:Before
After
This PR reduces some unnecessary struct nesting in the serialized output.