Use components for RobotPropertyKind #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #263, specifically this review comment about avoiding excessive serialization of Robot property data. The previous approach opted to store all Robot properties and property kinds in
jsonto avoid having to query multiple different components on load/save. This PR expanded on the plugin approach by triggering updates to components via the property plugin's systems and only serialize data when a value has changed.Another change is the use of a reusable plugin template
InspectRobotPropertyKindPluginwith widget systems for all Robot property kinds rather than having the widgets stored in a resource. This allows each of the property kind plugins to have better access to world variables, instead of having to pass variables throughShowRobotPropertyWidgetFnin the previous implementation.