-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! β€οΈ! ππ
Say hello by joining the conversation in our Discord
a820797
to
32bac91
Compare
Maybe I'm reading the failure wrong, but doesn't moving to Node.js 18.17.0 fix the engine issue?
|
I would think so, however it seems like something is quite seeing the npm and node change. Does |
Maybe needs fixing here also https://github.com/open-sauced/opengraph/blob/beta/Dockerfile#L20 |
The workflow files need to be updated to use the https://github.com/open-sauced/app/blob/beta/.github/workflows/compliance.yml#L15 |
d5184c3
to
90e62c7
Compare
This was helpful. I fix this PR with this - open-sauced/contributor.info@cd6bdc2 |
Not sure why this fails still. All the workflows are updated, the docker file etc. π« |
The workflows in |
We're using node 18 in the app https://github.com/open-sauced/app/blob/beta/.github/workflows/release.yml#L37 |
Il revert the node 20 upgrade then and just keep the updated workflows. Originally I thought it required Node 20, but it sounds like just updating workflows should be good. |
π This PR is included in version 2.4.1-beta.2 π The release is available on: Your semantic-release bot π¦π |
π This PR is included in version 2.5.0 π The release is available on: Your semantic-release bot π¦π |
Description
Sets the Node.js engine to a minimum of 18.17.0.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Relates to #72
Mobile & Desktop Screenshots/Recordings
Steps to QA
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?