Skip to content

Commit

Permalink
Merge branch 'main' into SC-20424-Otel-Contrib-Branch
Browse files Browse the repository at this point in the history
  • Loading branch information
AkhigbeEromo authored Jan 30, 2025
2 parents f7dbd24 + 800e0ca commit 5ee0bd1
Show file tree
Hide file tree
Showing 27 changed files with 336 additions and 354 deletions.
40 changes: 40 additions & 0 deletions .chloggen/configure_aws_sdk_retryer.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: resourcedetectionprocessor

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Expose additional configuration parameters for the AWS metadata client used by the EC2 detector

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [35936]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
In some cases, you might need to change the behavior of the AWS metadata client from the [standard retryer](https://docs.aws.amazon.com/sdk-for-go/v2/developer-guide/configure-retries-timeouts.html)
By default, the client retries 3 times with a max backoff delay of 20s.
We offer a limited set of options to override those defaults specifically, such that you can set the client to retry 10 times, for up to 5 minutes, for example:
```yaml
processors:
resourcedetection/ec2:
detectors: ["ec2"]
ec2:
max_attempts: 10
max_backoff: 5m
```
# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: tailsamplingprocessor

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Fixed sampling decision metrics `otelcol_processor_tail_sampling_sampling_trace_dropped_too_early` and `otelcol_processor_tail_sampling_sampling_policy_evaluation_error_total`, these were sometimes overcounted.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [37212]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
As a result of this change non-zero values of `otelcol_processor_tail_sampling_sampling_trace_dropped_too_early`
and `otelcol_processor_tail_sampling_sampling_policy_evaluation_error_total` metrics will be lower.
Before this fix, errors got counted several times depending on the amount of traces being processed
that tick and where in the batch the error happened.
Zero values are unaffected.
# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [user]
6 changes: 4 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,8 @@ chlog-update: $(CHLOGGEN)

.PHONY: genotelcontribcol
genotelcontribcol: $(BUILDER)
$(BUILDER) --skip-compilation --config cmd/otelcontribcol/builder-config.yaml
./internal/buildscripts/ocb-add-replaces.sh otelcontribcol
$(BUILDER) --skip-compilation --config cmd/otelcontribcol/builder-config-replaced.yaml

# Build the Collector executable.
.PHONY: otelcontribcol
Expand All @@ -356,7 +357,8 @@ otelcontribcollite: genotelcontribcol

.PHONY: genoteltestbedcol
genoteltestbedcol: $(BUILDER)
$(BUILDER) --skip-compilation --config cmd/oteltestbedcol/builder-config.yaml
./internal/buildscripts/ocb-add-replaces.sh oteltestbedcol
$(BUILDER) --skip-compilation --config cmd/oteltestbedcol/builder-config-replaced.yaml

# Build the Collector executable, with only components used in testbed.
.PHONY: oteltestbedcol
Expand Down
Loading

0 comments on commit 5ee0bd1

Please sign in to comment.