Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/elasticsearch] Support for profiles export #37567

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

[exporter/elasticsearch] Support for profiles export #37567

wants to merge 34 commits into from

Conversation

dmathieu
Copy link
Member

This adds support for exporting profiles within the elasticsearch exporter.

@dmathieu dmathieu mentioned this pull request Jan 29, 2025
Closed
dmathieu and others added 3 commits January 30, 2025 17:20
@dmathieu @florianl
Update exporter/elasticsearchexporter/internal/serializer/otelseriali…
0729b43 
…zer/serializeprofiles/transform.go

Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
@dmathieu
fix tests with removed fallback frame type
a915fbd
@dmathieu
fix core versions
3e0d86b
@dmathieu dmathieu force-pushed the elasticsearch-profiles branch from 593e97c to 3e0d86b Compare January 30, 2025 16:55
@dmathieu dmathieu force-pushed the elasticsearch-profiles branch 2 times, most recently from a5b356d to 112dcb2 Compare February 3, 2025 13:50
@dmathieu dmathieu force-pushed the elasticsearch-profiles branch from 112dcb2 to 81e972e Compare February 3, 2025 13:54
@dmathieu dmathieu marked this pull request as ready for review February 3, 2025 14:27
@dmathieu dmathieu requested a review from a team as a code owner February 3, 2025 14:27
@dmathieu dmathieu requested a review from fatsheep9146 February 3, 2025 14:27
@dmathieu
Copy link
Member Author

dmathieu commented Feb 3, 2025

This is ready for review.
Note that there's also #37500, which moves the other signals into the same internal package for otel serialization.

carsonip
carsonip reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments on the code under the assumption that @florianl already checked the profiling encoding logic

dmathieu and others added 2 commits February 4, 2025 14:22
@dmathieu @carsonip
Update exporter/elasticsearchexporter/exporter.go
7e4c20e 
Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
@dmathieu
remove unused ProfilesDynamicIndex
7598c5d
@dmathieu dmathieu force-pushed the elasticsearch-profiles branch from 4ee0401 to 059b0fc Compare February 4, 2025 13:42
@dmathieu dmathieu force-pushed the elasticsearch-profiles branch from 059b0fc to 86f6f97 Compare February 4, 2025 13:47
@dmathieu @rockdaboot
Update exporter/elasticsearchexporter/internal/serializer/otelseriali…
ed02380 
…zer/profile.go

Co-authored-by: Tim Rühsen <tim.ruehsen@gmx.de>
@dmathieu
Copy link
Member Author

dmathieu commented Feb 5, 2025

This PR is ready for review as a first setup that works.
There will be a couple more PRs adding performance improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianl florianl florianl approved these changes

@rockdaboot rockdaboot rockdaboot approved these changes

@mwear mwear mwear approved these changes

@carsonip carsonip carsonip approved these changes

@JaredTan95 JaredTan95 Awaiting requested review from JaredTan95

@lahsivjar lahsivjar Awaiting requested review from lahsivjar

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@mwear mwear

Labels
exporter/elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dmathieu @florianl @rockdaboot @mwear @carsonip