Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/github] add workflow run event trace handling #37578

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

adrielp
Copy link
Contributor

@adrielp adrielp commented Jan 29, 2025

Description

Adds functionality for creating a deterministic trace id and root span id coming from the workflow runs.

Link to tracking issue

Relates to #34944

Testing

Added tests and deployed locally.

Documentation

Updated the README to contain information about tracing.

@adrielp adrielp marked this pull request as ready for review February 3, 2025 01:32
@adrielp adrielp requested a review from a team as a code owner February 3, 2025 01:32
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just nits, looks good overall 👍

receiver/githubreceiver/trace_receiver.go Show resolved Hide resolved
receiver/githubreceiver/README.md Show resolved Hide resolved
receiver/githubreceiver/README.md Show resolved Hide resolved
receiver/githubreceiver/README.md Outdated Show resolved Hide resolved
receiver/githubreceiver/README.md Outdated Show resolved Hide resolved
receiver/githubreceiver/trace_event_handling.go Outdated Show resolved Hide resolved
receiver/githubreceiver/trace_event_handling.go Outdated Show resolved Hide resolved
receiver/githubreceiver/trace_event_handling.go Outdated Show resolved Hide resolved
receiver/githubreceiver/trace_event_handling.go Outdated Show resolved Hide resolved
receiver/githubreceiver/trace_receiver.go Show resolved Hide resolved
@adrielp adrielp requested a review from crobert-1 February 4, 2025 15:10
@adrielp adrielp requested a review from crobert-1 February 6, 2025 19:27
@adrielp
Copy link
Contributor Author

adrielp commented Feb 6, 2025

Known workflow failure in latest run. Issue #37757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants