remove redundant isDisposing pattern in StressTest #6082
+16
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
perf
|
bump |
| @@ -41,15 +47,5 @@ protected override void RunWorkItemInParallel() | |||
| recallReasonDescription: "due to a possible health risk from Listeria monocytogenes", | |||
| companyName: "Contoso Fresh Vegetables, Inc."); | |||
| } | |||
|
|
|||
| protected override void Dispose(bool isDisposing) | |||
There was a problem hiding this comment.
This follows the guidance from .NET - https://learn.microsoft.com/en-us/dotnet/standard/garbage-collection/implementing-dispose. Is there a strong reason why these test projects need a change? They are executed on an as-needed basis.
There was a problem hiding this comment.
that guidance is for unmanaged resources. re read the first paragraph
There was a problem hiding this comment.
as for “a strong reason”. removing redundant code should be reason enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Since no unmanaged resources are used and no finalizers to be suppressed
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes