remove Debug.Assert null checks

examples/Console/TestGrpcNetClient.cs

@@ -14,8 +14,6 @@ internal class TestGrpcNetClient
 {
     internal static int Run(GrpcNetClientOptions options)
     {
-        Debug.Assert(options != null, "options was null");
-
         // Prerequisite for running this example.
         // In a separate console window, start the example
         // ASP.NET Core gRPC service by running the following command

examples/Console/TestHttpClient.cs

@@ -17,8 +17,6 @@ internal class TestHttpClient
     // dotnet run httpclient
     internal static int Run(HttpClientOptions options)
     {
-        Debug.Assert(options != null, "options was null");
-
         System.Console.WriteLine("Hello World!");
 
         using var tracerProvider = Sdk.CreateTracerProviderBuilder()

src/OpenTelemetry.Api/Context/Propagation/TraceStateUtilsNew.cs

@@ -1,7 +1,7 @@
 // Copyright The OpenTelemetry Authors
 // SPDX-License-Identifier: Apache-2.0
 
 using System.Diagnostics;
 using System.Text;
 using OpenTelemetry.Internal;
 
@@ -24,8 +24,6 @@
     /// <returns>True if string was parsed successfully and tracestate was recognized, false otherwise.</returns>
     internal static bool AppendTraceState(string traceStateString, List<KeyValuePair<string, string>> tracestate)
     {
-        Debug.Assert(tracestate != null, "tracestate list cannot be null");
-
         if (string.IsNullOrEmpty(traceStateString))
         {
             return false;
@@ -56,7 +54,7 @@
                 var keyStr = key.ToString();
                 if (names.Add(keyStr))
                 {
-                    tracestate!.Add(new KeyValuePair<string, string>(keyStr, value.ToString()));
+                    tracestate.Add(new KeyValuePair<string, string>(keyStr, value.ToString()));
                 }
                 else
                 {

src/OpenTelemetry.Exporter.Console/Implementation/ConsoleTagWriter.cs

@@ -13,9 +13,7 @@ internal sealed class ConsoleTagWriter : JsonStringArrayTagWriter<ConsoleTagWrit
 
     public ConsoleTagWriter(Action<string, string> onUnsupportedTagDropped)
     {
-        Debug.Assert(onUnsupportedTagDropped != null, "onUnsupportedTagDropped was null");
-
-        this.onUnsupportedTagDropped = onUnsupportedTagDropped!;
+        this.onUnsupportedTagDropped = onUnsupportedTagDropped;
     }
 
     public bool TryTransformTag(KeyValuePair<string, object?> tag, out KeyValuePair<string, string> result)

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Builder/OtlpExporterBuilder.cs

@@ -24,24 +24,22 @@ internal OtlpExporterBuilder(
         string? name,
         IConfiguration? configuration)
     {
-        Debug.Assert(services != null, "services was null");
-
         if (configuration != null)
         {
             if (string.IsNullOrEmpty(name))
             {
                 name = "otlp";
             }
 
-            BindConfigurationToOptions(services!, name!, configuration);
+            BindConfigurationToOptions(services, name, configuration);
         }
 
         name ??= Options.DefaultName;
 
-        RegisterOtlpExporterServices(services!, name);
+        RegisterOtlpExporterServices(services, name);
 
         this.name = name;
-        this.Services = services!;
+        this.Services = services;
     }
 
     public IServiceCollection Services { get; }
@@ -119,9 +117,7 @@ public OtlpExporterBuilder ConfigureTracingProcessorOptions(
 
     private static void BindConfigurationToOptions(IServiceCollection services, string name, IConfiguration configuration)
     {
-        Debug.Assert(services != null, "services was null");
         Debug.Assert(!string.IsNullOrEmpty(name), "name was null or empty");
-        Debug.Assert(configuration != null, "configuration was null");
 
         /* Config JSON structure is expected to be something like this:
             {
@@ -152,33 +148,30 @@ private static void BindConfigurationToOptions(IServiceCollection services, stri
             }
         */
 
-        services!.Configure<OtlpExporterBuilderOptions>(name, configuration!);
+        services.Configure<OtlpExporterBuilderOptions>(name, configuration);
 
-        services!.Configure<LogRecordExportProcessorOptions>(
+        services.Configure<LogRecordExportProcessorOptions>(
             name, configuration!.GetSection(nameof(OtlpExporterBuilderOptions.LoggingOptions)));
 
-        services!.Configure<MetricReaderOptions>(
+        services.Configure<MetricReaderOptions>(
             name, configuration.GetSection(nameof(OtlpExporterBuilderOptions.MetricsOptions)));
 
-        services!.Configure<ActivityExportProcessorOptions>(
+        services.Configure<ActivityExportProcessorOptions>(
             name, configuration.GetSection(nameof(OtlpExporterBuilderOptions.TracingOptions)));
     }
 
     private static void RegisterOtlpExporterServices(IServiceCollection services, string name)
     {
-        Debug.Assert(services != null, "services was null");
-        Debug.Assert(name != null, "name was null");
-
-        services!.AddOtlpExporterLoggingServices();
-        services!.AddOtlpExporterMetricsServices(name!);
-        services!.AddOtlpExporterTracingServices();
+        services.AddOtlpExporterLoggingServices();
+        services.AddOtlpExporterMetricsServices(name!);
+        services.AddOtlpExporterTracingServices();
 
         // Note: UseOtlpExporterRegistration is added to the service collection
         // for each invocation to detect repeated calls to "UseOtlpExporter" and
         // to throw if "AddOtlpExporter" extensions are called
-        services!.AddSingleton(UseOtlpExporterRegistration.Instance);
+        services.AddSingleton(UseOtlpExporterRegistration.Instance);
 
-        services!.RegisterOptionsFactory((sp, configuration, name) => new OtlpExporterBuilderOptions(
+        services.RegisterOptionsFactory((sp, configuration, name) => new OtlpExporterBuilderOptions(
             configuration,
             /* Note: We don't use name for SdkLimitOptions. There should only be
             one provider for a given service collection so SdkLimitOptions is
@@ -195,10 +188,10 @@ there but that may change in the future so it is handled
             sp.GetService<IOptionsMonitor<MetricReaderOptions>>()?.Get(name),
             sp.GetService<IOptionsMonitor<ActivityExportProcessorOptions>>()?.Get(name)));
 
-        services!.ConfigureOpenTelemetryLoggerProvider(
+        services.ConfigureOpenTelemetryLoggerProvider(
             (sp, logging) =>
             {
-                var builderOptions = GetBuilderOptionsAndValidateRegistrations(sp, name!);
+                var builderOptions = GetBuilderOptionsAndValidateRegistrations(sp, name);
 
                 var processor = OtlpLogExporterHelperExtensions.BuildOtlpLogExporter(
                     sp,
@@ -213,10 +206,10 @@ there but that may change in the future so it is handled
                 logging.AddProcessor(processor);
             });
 
-        services!.ConfigureOpenTelemetryMeterProvider(
+        services.ConfigureOpenTelemetryMeterProvider(
             (sp, metrics) =>
             {
-                var builderOptions = GetBuilderOptionsAndValidateRegistrations(sp, name!);
+                var builderOptions = GetBuilderOptionsAndValidateRegistrations(sp, name);
 
                 metrics.AddReader(
                     OtlpMetricExporterExtensions.BuildOtlpExporterMetricReader(
@@ -227,10 +220,10 @@ there but that may change in the future so it is handled
                         skipUseOtlpExporterRegistrationCheck: true));
             });
 
-        services!.ConfigureOpenTelemetryTracerProvider(
+        services.ConfigureOpenTelemetryTracerProvider(
             (sp, tracing) =>
             {
-                var builderOptions = GetBuilderOptionsAndValidateRegistrations(sp, name!);
+                var builderOptions = GetBuilderOptionsAndValidateRegistrations(sp, name);
 
                 var processorOptions = builderOptions.ActivityExportProcessorOptions ?? throw new InvalidOperationException("ActivityExportProcessorOptions were missing with tracing enabled");
 

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Builder/OtlpExporterBuilderOptions.cs

@@ -31,25 +31,21 @@ internal OtlpExporterBuilderOptions(
         MetricReaderOptions? metricReaderOptions,
         ActivityExportProcessorOptions? activityExportProcessorOptions)
     {
-        Debug.Assert(configuration != null, "configuration was null");
-        Debug.Assert(sdkLimitOptions != null, "sdkLimitOptions was null");
-        Debug.Assert(experimentalOptions != null, "experimentalOptions was null");
-
-        this.SdkLimitOptions = sdkLimitOptions!;
-        this.ExperimentalOptions = experimentalOptions!;
+        this.SdkLimitOptions = sdkLimitOptions;
+        this.ExperimentalOptions = experimentalOptions;
         this.LogRecordExportProcessorOptions = logRecordExportProcessorOptions;
         this.MetricReaderOptions = metricReaderOptions;
         this.ActivityExportProcessorOptions = activityExportProcessorOptions;
 
         var defaultBatchOptions = this.ActivityExportProcessorOptions!.BatchExportProcessorOptions;
 
-        this.DefaultOptionsInstance = new OtlpExporterOptions(configuration!, OtlpExporterOptionsConfigurationType.Default, defaultBatchOptions);
+        this.DefaultOptionsInstance = new OtlpExporterOptions(configuration, OtlpExporterOptionsConfigurationType.Default, defaultBatchOptions);
 
-        this.LoggingOptionsInstance = new OtlpExporterOptions(configuration!, OtlpExporterOptionsConfigurationType.Logs, defaultBatchOptions);
+        this.LoggingOptionsInstance = new OtlpExporterOptions(configuration, OtlpExporterOptionsConfigurationType.Logs, defaultBatchOptions);
 
-        this.MetricsOptionsInstance = new OtlpExporterOptions(configuration!, OtlpExporterOptionsConfigurationType.Metrics, defaultBatchOptions);
+        this.MetricsOptionsInstance = new OtlpExporterOptions(configuration, OtlpExporterOptionsConfigurationType.Metrics, defaultBatchOptions);
 
-        this.TracingOptionsInstance = new OtlpExporterOptions(configuration!, OtlpExporterOptionsConfigurationType.Traces, defaultBatchOptions);
+        this.TracingOptionsInstance = new OtlpExporterOptions(configuration, OtlpExporterOptionsConfigurationType.Traces, defaultBatchOptions);
     }
 
     public IOtlpExporterOptions DefaultOptions => this.DefaultOptionsInstance;

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OtlpServiceCollectionExtensions.cs

@@ -13,19 +13,14 @@ internal static class OtlpServiceCollectionExtensions
 {
     public static void AddOtlpExporterLoggingServices(this IServiceCollection services)
     {
-        Debug.Assert(services != null, "services was null");
-
-        AddOtlpExporterSharedServices(services!, registerSdkLimitOptions: true);
+        AddOtlpExporterSharedServices(services, registerSdkLimitOptions: true);
     }
 
     public static void AddOtlpExporterMetricsServices(this IServiceCollection services, string name)
     {
-        Debug.Assert(services != null, "services was null");
-        Debug.Assert(name != null, "name was null");
-
-        AddOtlpExporterSharedServices(services!, registerSdkLimitOptions: false);
+        AddOtlpExporterSharedServices(services, registerSdkLimitOptions: false);
 
-        services!.AddOptions<MetricReaderOptions>(name).Configure<IConfiguration>(
+        services.AddOptions<MetricReaderOptions>(name).Configure<IConfiguration>(
             (readerOptions, config) =>
             {
                 var otlpTemporalityPreference = config[OtlpSpecConfigDefinitions.MetricsTemporalityPreferenceEnvVarName];
@@ -39,9 +34,7 @@ public static void AddOtlpExporterMetricsServices(this IServiceCollection servic
 
     public static void AddOtlpExporterTracingServices(this IServiceCollection services)
     {
-        Debug.Assert(services != null, "services was null");
-
-        AddOtlpExporterSharedServices(services!, registerSdkLimitOptions: true);
+        AddOtlpExporterSharedServices(services, registerSdkLimitOptions: true);
     }
 
     private static void AddOtlpExporterSharedServices(

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/Serializer/ProtobufSerializer.cs

@@ -284,8 +284,6 @@ internal static int ComputeVarInt64Size(ulong value)
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     internal static int WriteStringWithTag(byte[] buffer, int writePosition, int fieldNumber, string value)
     {
-        Debug.Assert(value != null, "value was null");
-
         return WriteStringWithTag(buffer, writePosition, fieldNumber, value.AsSpan());
     }
 

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/Transmission/OtlpExporterPersistentStorageTransmissionHandler.cs

@@ -26,8 +26,7 @@ public OtlpExporterPersistentStorageTransmissionHandler(IExportClient exportClie
     internal OtlpExporterPersistentStorageTransmissionHandler(PersistentBlobProvider persistentBlobProvider, IExportClient exportClient, double timeoutMilliseconds)
         : base(exportClient, timeoutMilliseconds)
     {
-        Debug.Assert(persistentBlobProvider != null, "persistentBlobProvider was null");
-        this.persistentBlobProvider = persistentBlobProvider!;
+        this.persistentBlobProvider = persistentBlobProvider;
 
         this.thread = new Thread(this.RetryStoredRequests)
         {
@@ -48,8 +47,7 @@ internal bool InitiateAndWaitForRetryProcess(int timeOutMilliseconds)
 
     protected override bool OnSubmitRequestFailure(byte[] request, int contentLength, ExportClientResponse response)
     {
-        Debug.Assert(request != null, "request was null");
-        return RetryHelper.ShouldRetryRequest(response, OtlpRetry.InitialBackoffMilliseconds, out _) && this.persistentBlobProvider.TryCreateBlob(request!, out _);
+        return RetryHelper.ShouldRetryRequest(response, OtlpRetry.InitialBackoffMilliseconds, out _) && this.persistentBlobProvider.TryCreateBlob(request, out _);
     }
 
     protected override void OnShutdown(int timeoutMilliseconds)

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs

@@ -62,8 +62,6 @@ internal OtlpExporterOptions(
         OtlpExporterOptionsConfigurationType configurationType,
         BatchExportActivityProcessorOptions defaultBatchOptions)
     {
-        Debug.Assert(defaultBatchOptions != null, "defaultBatchOptions was null");
-
         this.ApplyConfiguration(configuration, configurationType);
 
         this.DefaultHttpClientFactory = () =>
@@ -74,7 +72,7 @@ internal OtlpExporterOptions(
             };
         };
 
-        this.BatchExportProcessorOptions = defaultBatchOptions!;
+        this.BatchExportProcessorOptions = defaultBatchOptions;
     }
 
     /// <inheritdoc/>
@@ -230,16 +228,14 @@ private void ApplyConfiguration(
         IConfiguration configuration,
         OtlpExporterOptionsConfigurationType configurationType)
     {
-        Debug.Assert(configuration != null, "configuration was null");
-
         // Note: When using the "AddOtlpExporter" extensions configurationType
         // never has a value other than "Default" because OtlpExporterOptions is
         // shared by all signals and there is no way to differentiate which
         // signal is being constructed.
         if (configurationType == OtlpExporterOptionsConfigurationType.Default)
         {
             this.ApplyConfigurationUsingSpecificationEnvVars(
-                configuration!,
+                configuration,
                 OtlpSpecConfigDefinitions.DefaultEndpointEnvVarName,
                 appendSignalPathToEndpoint: true,
                 OtlpSpecConfigDefinitions.DefaultProtocolEnvVarName,
@@ -249,7 +245,7 @@ private void ApplyConfiguration(
         else if (configurationType == OtlpExporterOptionsConfigurationType.Logs)
         {
             this.ApplyConfigurationUsingSpecificationEnvVars(
-                configuration!,
+                configuration,
                 OtlpSpecConfigDefinitions.LogsEndpointEnvVarName,
                 appendSignalPathToEndpoint: false,
                 OtlpSpecConfigDefinitions.LogsProtocolEnvVarName,
@@ -259,7 +255,7 @@ private void ApplyConfiguration(
         else if (configurationType == OtlpExporterOptionsConfigurationType.Metrics)
         {
             this.ApplyConfigurationUsingSpecificationEnvVars(
-                configuration!,
+                configuration,
                 OtlpSpecConfigDefinitions.MetricsEndpointEnvVarName,
                 appendSignalPathToEndpoint: false,
                 OtlpSpecConfigDefinitions.MetricsProtocolEnvVarName,
@@ -269,7 +265,7 @@ private void ApplyConfiguration(
         else if (configurationType == OtlpExporterOptionsConfigurationType.Traces)
         {
             this.ApplyConfigurationUsingSpecificationEnvVars(
-                configuration!,
+                configuration,
                 OtlpSpecConfigDefinitions.TracesEndpointEnvVarName,
                 appendSignalPathToEndpoint: false,
                 OtlpSpecConfigDefinitions.TracesProtocolEnvVarName,

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpLogExporter.cs

@@ -52,18 +52,14 @@ internal OtlpLogExporter(
         ExperimentalOptions experimentalOptions,
         OtlpExporterTransmissionHandler? transmissionHandler = null)
     {
-        Debug.Assert(exporterOptions != null, "exporterOptions was null");
-        Debug.Assert(sdkLimitOptions != null, "sdkLimitOptions was null");
-        Debug.Assert(experimentalOptions != null, "experimentalOptions was null");
-
-        this.experimentalOptions = experimentalOptions!;
-        this.sdkLimitOptions = sdkLimitOptions!;
+        this.experimentalOptions = experimentalOptions;
+        this.sdkLimitOptions = sdkLimitOptions;
 #if NET462_OR_GREATER || NETSTANDARD2_0
         this.startWritePosition = 0;
 #else
-        this.startWritePosition = exporterOptions!.Protocol == OtlpExportProtocol.Grpc ? GrpcStartWritePosition : 0;
+        this.startWritePosition = exporterOptions.Protocol == OtlpExportProtocol.Grpc ? GrpcStartWritePosition : 0;
 #endif
-        this.transmissionHandler = transmissionHandler ?? exporterOptions!.GetExportTransmissionHandler(experimentalOptions!, OtlpSignalType.Logs);
+        this.transmissionHandler = transmissionHandler ?? exporterOptions.GetExportTransmissionHandler(experimentalOptions, OtlpSignalType.Logs);
     }
 
     internal Resource Resource => this.resource ??= this.ParentProvider.GetResource();

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpLogExporterHelperExtensions.cs

@@ -278,15 +278,9 @@ internal static BaseProcessor<LogRecord> BuildOtlpLogExporter(
         bool skipUseOtlpExporterRegistrationCheck = false,
         Func<BaseExporter<LogRecord>, BaseExporter<LogRecord>>? configureExporterInstance = null)
     {
-        Debug.Assert(serviceProvider != null, "serviceProvider was null");
-        Debug.Assert(exporterOptions != null, "exporterOptions was null");
-        Debug.Assert(processorOptions != null, "processorOptions was null");
-        Debug.Assert(sdkLimitOptions != null, "sdkLimitOptions was null");
-        Debug.Assert(experimentalOptions != null, "experimentalOptions was null");
-
         if (!skipUseOtlpExporterRegistrationCheck)
         {
-            serviceProvider!.EnsureNoUseOtlpExporterRegistrations();
+            serviceProvider.EnsureNoUseOtlpExporterRegistrations();
         }
 
         /*
@@ -306,16 +300,16 @@ internal static BaseProcessor<LogRecord> BuildOtlpLogExporter(
          */
 
         BaseExporter<LogRecord> otlpExporter = new OtlpLogExporter(
-            exporterOptions!,
-            sdkLimitOptions!,
-            experimentalOptions!);
+            exporterOptions,
+            sdkLimitOptions,
+            experimentalOptions);
 
         if (configureExporterInstance != null)
         {
             otlpExporter = configureExporterInstance(otlpExporter);
         }
 
-        if (processorOptions!.ExportProcessorType == ExportProcessorType.Simple)
+        if (processorOptions.ExportProcessorType == ExportProcessorType.Simple)
         {
             return new SimpleLogRecordExportProcessor(otlpExporter);
         }