Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci-lint to 1.63.4 #311

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Bump golangci-lint to 1.63.4 #311

merged 1 commit into from
Jan 17, 2025

Conversation

rockdaboot
Copy link
Contributor

@rockdaboot rockdaboot commented Jan 16, 2025 •
edited
Loading

Update golangci-lint to 1.63.4.

Noteworthy changes

  • Fixing .golangci-lint for
WARN [lintersdb] The linter "gomnd" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle 
WARN [lintersdb] The linter "execinquery" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle 
WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.

@rockdaboot rockdaboot self-assigned this Jan 16, 2025
@rockdaboot rockdaboot requested review from a team as code owners January 16, 2025 10:32
@rockdaboot rockdaboot force-pushed the tim/golangci-lint-1.63.4 branch from fe90994 to 1db1fd1 Compare January 17, 2025 14:45
@rockdaboot rockdaboot merged commit 2698137 into open-telemetry:main Jan 17, 2025
24 checks passed
@rockdaboot rockdaboot deleted the tim/golangci-lint-1.63.4 branch January 17, 2025 15:09
teresanovielloatinstana added a commit to instana/opentelemetry-ebpf-profiler that referenced this pull request Jan 17, 2025
@teresanovielloatinstana
Sync from upstream (2025-01-17) (#11)
e2ebf7c 
* Bump golangci-lint to 1.63.4 (open-telemetry#311)
  Author: Tim Rühsen <tim.ruhsen@elastic.co>

* CI: reduce boiler plate of environment (open-telemetry#312)
* Consistent format of the eBPF code (open-telemetry#310)
* Off CPU profiling (open-telemetry#196)
* CI: Check for differences in the eBPF binary blobs (open-telemetry#305)
* README: drop make target docker-image as pre requirement (open-telemetry#304)
  Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* Setup collector receiver (open-telemetry#160)
  Author: Damien Mathieu <42@dmathieu.com>
  Co-authored-by: Tim Rühsen <tim.ruhsen@elastic.co>

* Send process name as process.executable.name (/proc/PID/comm) (open-telemetry#298)
  Author: Christos Kalkanis <christos.kalkanis@elastic.co>
  Co-authored-by: Tim Rühsen <tim.ruhsen@elastic.co>

* Remove host metadata collector (open-telemetry#299)
  Author: Damien Mathieu <42@dmathieu.com>

* apmint: return error if Attach() fails (open-telemetry#271)
* docker: build and push docker builder image (open-telemetry#297)
  Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* Update golang.org/x/net to v0.33.0 (Fix CVE-2024-45338) (open-telemetry#294)
  Author: Tim Rühsen <tim.ruhsen@elastic.co>

* metrics: update package documentation (open-telemetry#295)
  Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* Fix pdata function table order (open-telemetry#286)
  Author: Tolya Korniltsev <korniltsev.anatoly@gmail.com>

* Fix cross-compilation (open-telemetry#282) (open-telemetry#290)
  Author: Christos Kalkanis <christos.kalkanis@elastic.co>

* Use clang-17 for building tracers (open-telemetry#270)
  Author: Mathieu Bressolle-Chataigner <mathieu@konvu.com>
  Co-authored-by: Co-authored-by: Christos Kalkanis
<christos.kalkanis@elastic.co>

* Make the CollAgentAddr config optional in controller (open-telemetry#279)
  Author: Damien Mathieu <42@dmathieu.com>
  Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
  Co-authored-by: Florian Lehner <florian.lehner@elastic.co>

* Remove unused type libpf.TraceAndCounts (open-telemetry#283)
  Author: Tim Rühsen <tim.ruhsen@elastic.co>

* Collector Reporter (open-telemetry#208)
  Author: Damien Mathieu <42@dmathieu.com>
  Co-authored-by: Tim Rühsen <tim.ruehsen@gmx.de>
  Co-authored-by: Florian Lehner <florian.lehner@elastic.co>
  Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>

* proc: handle nvidia kernel modules (open-telemetry#274)
* README: provide new version of devfiler (open-telemetry#275)
  Author: Florian Lehner <florian.lehner@elastic.co>

* Extract reporter data generation, and use pdata (open-telemetry#245)
  Author: Damien Mathieu <42@dmathieu.com>
  Co-authored-by: Florian Lehner <florian.lehner@elastic.co>
  Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>

* apmint: warn user about changes in the APM service (open-telemetry#269)
  Author: Florian Lehner <florian.lehner@elastic.co>
  Co-authored-by: Joel Höner <joel@elastic.co>

* coredump: no need for full dump with bundled files (open-telemetry#213)
  Author: Timo Teräs <timo.teras@iki.fi>

* Send executable path with every stack trace (open-telemetry#253)
* Send thread name as ThreadNameKey not ProcessCommandKey (open-telemetry#265)
  Author: Christos Kalkanis <christos.kalkanis@elastic.co>

* proc: Fix parsing Kernel Module lines where refcount is - (open-telemetry#263)
  Author: Frederic Branczyk <fbranczyk@gmail.com>

* reporter: extend lifetime for cached elements (open-telemetry#260)
  Author: Florian Lehner <florian.lehner@elastic.co>

* Reporter:  allow extending samples with extra attributes (open-telemetry#237)
  Author: Joel Höner <joel@elastic.co>
  Co-authored-by: Tim Rühsen <tim.ruehsen@gmx.de>
teresanovielloatinstana added a commit to instana/opentelemetry-ebpf-profiler that referenced this pull request Jan 21, 2025
@teresanovielloatinstana
Sync from upstream (2025-01-17) (#11)
270db14 
* Bump golangci-lint to 1.63.4 (open-telemetry#311)
  Author: Tim Rühsen <tim.ruhsen@elastic.co>

* CI: reduce boiler plate of environment (open-telemetry#312)
* Consistent format of the eBPF code (open-telemetry#310)
* Off CPU profiling (open-telemetry#196)
* CI: Check for differences in the eBPF binary blobs
  (open-telemetry#305)
* README: drop make target docker-image as pre requirement
  (open-telemetry#304)
  Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* Setup collector receiver (open-telemetry#160)
  Author: Damien Mathieu <42@dmathieu.com>
  Co-authored-by: Tim Rühsen <tim.ruhsen@elastic.co>

* Send process name as process.executable.name (/proc/PID/comm)
  (open-telemetry#298)
  Author: Christos Kalkanis <christos.kalkanis@elastic.co>
  Co-authored-by: Tim Rühsen <tim.ruhsen@elastic.co>

* Remove host metadata collector (open-telemetry#299)
  Author: Damien Mathieu <42@dmathieu.com>

* apmint: return error if Attach() fails (open-telemetry#271)
* docker: build and push docker builder image (open-telemetry#297)
  Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* Update golang.org/x/net to v0.33.0 (Fix CVE-2024-45338)
  (open-telemetry#294)
  Author: Tim Rühsen <tim.ruhsen@elastic.co>

* metrics: update package documentation (open-telemetry#295)
  Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* Fix pdata function table order (open-telemetry#286)
  Author: Tolya Korniltsev <korniltsev.anatoly@gmail.com>

* Fix cross-compilation (open-telemetry#282) (open-telemetry#290)
  Author: Christos Kalkanis <christos.kalkanis@elastic.co>

* Use clang-17 for building tracers (open-telemetry#270)
  Author: Mathieu Bressolle-Chataigner <mathieu@konvu.com>
  Co-authored-by: Co-authored-by: Christos Kalkanis
<christos.kalkanis@elastic.co>

* Make the CollAgentAddr config optional in controller
  (open-telemetry#279)
  Author: Damien Mathieu <42@dmathieu.com>
  Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
  Co-authored-by: Florian Lehner <florian.lehner@elastic.co>

* Remove unused type libpf.TraceAndCounts (open-telemetry#283)
  Author: Tim Rühsen <tim.ruhsen@elastic.co>

* Collector Reporter (open-telemetry#208)
  Author: Damien Mathieu <42@dmathieu.com>
  Co-authored-by: Tim Rühsen <tim.ruehsen@gmx.de>
  Co-authored-by: Florian Lehner <florian.lehner@elastic.co>
  Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>

* proc: handle nvidia kernel modules (open-telemetry#274)
* README: provide new version of devfiler (open-telemetry#275)
  Author: Florian Lehner <florian.lehner@elastic.co>

* Extract reporter data generation, and use pdata (open-telemetry#245)
  Author: Damien Mathieu <42@dmathieu.com>
  Co-authored-by: Florian Lehner <florian.lehner@elastic.co>
  Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>

* apmint: warn user about changes in the APM service
  (open-telemetry#269)
  Author: Florian Lehner <florian.lehner@elastic.co>
  Co-authored-by: Joel Höner <joel@elastic.co>

* coredump: no need for full dump with bundled files
  (open-telemetry#213)
  Author: Timo Teräs <timo.teras@iki.fi>

* Send executable path with every stack trace (open-telemetry#253)
* Send thread name as ThreadNameKey not ProcessCommandKey
  (open-telemetry#265)
  Author: Christos Kalkanis <christos.kalkanis@elastic.co>

* proc: Fix parsing Kernel Module lines where refcount is -
  (open-telemetry#263)
  Author: Frederic Branczyk <fbranczyk@gmail.com>

* reporter: extend lifetime for cached elements (open-telemetry#260)
  Author: Florian Lehner <florian.lehner@elastic.co>

* Reporter:  allow extending samples with extra attributes
  (open-telemetry#237)
  Author: Joel Höner <joel@elastic.co>
  Co-authored-by: Tim Rühsen <tim.ruehsen@gmx.de>
@teresanovielloatinstana teresanovielloatinstana mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christos68k christos68k christos68k approved these changes

@florianl florianl florianl approved these changes

Assignees

@rockdaboot rockdaboot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rockdaboot @florianl @christos68k