support stripped binaries built wit CGO_ENABLED #1641
+48
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
reviewed
Jan 22, 2025
| .PHONY: sample-app/nethttp sample-app/gin sample-app/databasesql sample-app/nethttp-custom sample-app/otelglobal sample-app/autosdk sample-app/kafka-go | ||
| .PHONY: sample-app/% |
There was a problem hiding this comment.
This is not expanded in a .PHONY target. It removes the functionality and completion of this target. It should not be changed.
There was a problem hiding this comment.
The current version of the Makefile is not working for me for the fixture targets. The sample-app targets are not executed.
make sample-app/nethttp
make: Nothing to be done for `sample-app/nethttp'.This change fixed that, I'm not sure why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1637 and improves our support for stripped binaries.
.gosymtabsection is not required to parse the pcln table as stated in https://pkg.go.dev/debug/gosym#NewTableruntime.textsymbol from the instrumented binary. For binaries not including C code, this is the same as the start of the.textsection. However for those that use C code, this value will differ. This caused incorrect offsets to get probed when instrumenting a stripped binary that uses a CGO lib. An example of this is our DB example and test which uses the go-sqlite3 library.