Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding export retry configuration #1341

Closed
wants to merge 4 commits into from

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jun 27, 2024

Closes #1317

@brettmc
Copy link
Collaborator Author

brettmc commented Jun 27, 2024

This is set to draft, as open-telemetry/opentelemetry-configuration#97 has not been accepted.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 74.16%. Comparing base (b6f9afb) to head (4632de4).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
...K/ComponentProvider/Logs/LogRecordExporterOtlp.php 0.00% 9 Missing ⚠️
...K/ComponentProvider/Metrics/MetricExporterOtlp.php 0.00% 9 Missing ⚠️
...g/SDK/ComponentProvider/Trace/SpanExporterOtlp.php 0.00% 9 Missing ⚠️
...SDK/ComponentProvider/Trace/SpanExporterZipkin.php 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1341      +/-   ##
============================================
- Coverage     74.54%   74.16%   -0.38%     
  Complexity     2504     2504              
============================================
  Files           355      355              
  Lines          7180     7216      +36     
============================================
  Hits           5352     5352              
- Misses         1828     1864      +36     
Flag Coverage Δ
8.1 73.93% <0.00%> (-0.35%) ⬇️
8.2 74.11% <0.00%> (-0.38%) ⬇️
8.3 74.11% <0.00%> (-0.40%) ⬇️
8.4 74.14% <0.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...K/ComponentProvider/Logs/LogRecordExporterOtlp.php 0.00% <0.00%> (ø)
...K/ComponentProvider/Metrics/MetricExporterOtlp.php 0.00% <0.00%> (ø)
...g/SDK/ComponentProvider/Trace/SpanExporterOtlp.php 0.00% <0.00%> (ø)
...SDK/ComponentProvider/Trace/SpanExporterZipkin.php 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f9afb...4632de4. Read the comment docs.

@brettmc
Copy link
Collaborator Author

brettmc commented Dec 24, 2024

Closing, can be re-opened or re-implemented if/when the spec allows.

@brettmc brettmc closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to configure timeout and retry of exporter
2 participants